fix(sig): match hover state to form theme color#9527
Merged
Conversation
* fix: signature field hover state follows form theme color * refactor: match existing theming pattern for signature field
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the signature field's hover and active stroke colors so they follow the form's theme color rather than a hardcoded blue (#445fcd), matching the behavior of other field types.
Changes:
- Adds an optional
colorThemeprop toSignatureCanvas(defaulting toFormColorTheme.Blue) and threads it through fromSignatureField. - Replaces the hardcoded
#445fcdborder/outline andprimary.100hover background withtheme-${colorTheme}.500andtheme-${colorTheme}.100semantic tokens.
Contributor
|
Thanks for working on this @LoneRifle. There are a couple of other areas where the button color is also inconsistently not following the form theme color:
Since we're tracking this as part of 1 ticket, would it be possible to ask for scope creep and implement these changes to those components as well? |
Contributor
Author
|
@scottheng96 I defer to @rickysurya . Could you create a separate GitHub issue for this so that I can have the changes merged in via external contributions? Alternatively, you can launch a GitHub Copilot agent to work on it |
Contributor
|
@LoneRifle @rickysurya Can - we can go ahead with this first then 👍 |
scottheng96
approved these changes
Jun 4, 2026
eliotlim
added a commit
that referenced
this pull request
Jun 4, 2026
* chore: add agent context and scratch to gitignore (#9544) * Merge pull request #9545 from opengovsg/fix/optional-pdf-display fix: render signature question with empty answer when signature is not captured in PDF * Merge pull request #9465 from opengovsg/feat/create-form-modal-cutover feat(mrf-cutover): default CreateFormModal to MRF with storage-mode escape hatch (4/6) * fix(NumberField): remove +/- stepper buttons (#9444) (#9448) Co-authored-by: dew1997 <109208984+dew1997@users.noreply.github.com> * fix: enable line breaks in thank you page message (#9507) * fix: enable line breaks in thank you page message (#9433) * fix: lint frontend EndPageBlock (#9509) Fix frontend lint error in EndPageBlock Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> --------- Co-authored-by: Bhanu Pratap Singh Rathore <bhanur05@gmail.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> * Merge pull request #9527 from opengovsg/fix/signature-hover-theme-color fix(sig): match hover state to form theme color * fix(table): add default for dropdown columns (#9526) fix(table): add default for dropdown columns (#9476) Co-authored-by: Raj Shekar Patha <rajashekarpatha07@gmail.com> * feat(i18n): add landing payments and not found error pages (#9522) * feat(i18n): add landing payments and not found error pages (#9497) feat: add i18n for landing payments and not found error pages * fix(i18n/payments): remove spurious whitespace Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * fix(payments): add i18n t hook to `useCallback()` --------- Co-authored-by: Samuel Tan <126168312+SAMTAN444@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * chore: bump version to 7.23.0 --------- Co-authored-by: Kevin Foong <55353265+kevin9foong@users.noreply.github.com> Co-authored-by: scottheng96 <44297674+scottheng96@users.noreply.github.com> Co-authored-by: LoneRifle <LoneRifle@users.noreply.github.com> Co-authored-by: dew1997 <109208984+dew1997@users.noreply.github.com> Co-authored-by: Bhanu Pratap Singh Rathore <bhanur05@gmail.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: Raj Shekar Patha <rajashekarpatha07@gmail.com> Co-authored-by: Samuel Tan <126168312+SAMTAN444@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and Solution
Closes #9347
Merges #9441