[SAFE-EMAIL-TEST-2] PLU-386: make postman email test step send only to the pipe owner#1649
Open
ogp-weeloong wants to merge 1 commit into
Open
Conversation
ogp-weeloong
force-pushed
the
feat/ses/safe-test-emails/action
branch
from
1063774 to
33324e3
Compare
Contributor
Author
1 task
ogp-weeloong
force-pushed
the
feat/ses/safe-test-emails/action
branch
from
33324e3 to
b6a5124
Compare
4 tasks
ogp-weeloong
changed the title
kevinkim-ogp
approved these changes
Jun 2, 2026
Contributor
kevinkim-ogp
left a comment
kevinkim-ogp
left a comment
There was a problem hiding this comment.
lgtm, tested and verified it works
Sending a "Send email" test step previously delivered to whatever recipients were configured on the step, which could spam unrelated people while a builder iterated on a template. The action now rewrites both `destinationEmail` and `destinationEmailCc` to `$.user.email` when `$.execution.testRun` is true, and surfaces a `testStepTooltip` on the Check step button so the user knows test emails will only go to their own address. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
ogp-weeloong
force-pushed
the
feat/ses/safe-test-emails/tooltip
branch
from
c847a08 to
6afa940
Compare
ogp-weeloong
force-pushed
the
feat/ses/safe-test-emails/action
branch
from
b6a5124 to
3c765b5
Compare
Contributor
Author
|
Updating UX in #1675 as discussed over sync |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When testing email, we want to always send the email only to the pipe owner. This prevents them from accidentally sending a real email to their target audience when testing.
Solution
High level: when calling postman's API, clear CC list and force recipient to pipe owner if the run is a test run.
We want to add a UX signal to let the pipe owner know that when they click test step in postman, the email will be sent to them.
I decided on showing a tooltip. However, I'm not 100% sure if tooltip is good enough - we may want to do a NUX / first time modal instead.
This PR
Adds a frontend extension for postman send email action to apply a new test step tooltip, and also updates the postman backend logic as described in the solution
Tests