[VIBES-1] PLU-758: add agent skills + tighten claude.md rules#1664
Merged
Conversation
Contributor
Author
How to use the Graphite Merge QueueAdd the label lfg to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
ogp-weeloong
changed the title
pregnantboy
reviewed
Jun 2, 2026
Contributor
pregnantboy
left a comment
pregnantboy
left a comment
There was a problem hiding this comment.
lets get this merged in asap
but some comments first:
- there's quite a lot of framework-specific files (react 19, next, nest, trpc, etc.), will claude get confused by this if we dont?
- what's skills-lock.json for?
Contributor
Author
|
removed backend skills (which also removes these framework-specific references etc) for now, let's look at backend skills later |
ogp-weeloong
force-pushed
the
chore/claude/skills
branch
2 times, most recently
from
cf117f7 to
48961c3
Compare
Merge activity
|
## Summary Install agent skills + tighten repo-wide rules for a better "vibe coding" experience. No runtime code changes. ## Changes **Skills installed** (via [`skills.sh`](https://skills.sh), tracked in `skills-lock.json`): - Root: `caveman`, `graphite` - Frontend: `vercel-react-best-practices`, `vercel-composition-patterns` **Tooling** - New `lint:fix` script (`eslint --fix && tsc --noEmit`) in both workspaces + root fan-out - This is to allow the agent to apply our lints after authoring files. **`.claude/CLAUDE.md`** — new conventions: - npm-only; install with `-E`. - Run `lint:fix` then `lint` before committing; scope to the workspace touched. - Branches / PRs via Graphite + the `graphite` skill; ask before naming a branch (`feat/...` or `chore/...`). - Skills section: upstream (in `skills-lock.json`) is read-only; overrides go in `CLAUDE.md`. Plumber-specific skills scaffold via `skills init`. **`.claude/rules/backend.md`**: add unit tests for new code; prefer REST over new root GraphQL fields. ## Review notes ~12k LoC of the diff is vendored skill content — focus on `CLAUDE.md`, `rules/backend.md`, the `package.json` changes, and the `skills-lock.json` files. Engineers need `skills.sh` installed globally.
graphite-app
Bot
force-pushed
the
chore/claude/skills
branch
from
48961c3 to
793fe29
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Install agent skills + tighten repo-wide rules for a better "vibe coding" experience. No runtime code changes.
Changes
Skills installed (via
skills.sh, tracked inskills-lock.json):caveman,graphitevercel-react-best-practices,vercel-composition-patternsTooling
lint:fixscript (eslint --fix && tsc --noEmit) in both workspaces + root fan-out.claude/CLAUDE.md— new conventions:-E.lint:fixthenlintbefore committing; scope to the workspace touched.graphiteskill; ask before naming a branch (feat/...orchore/...).skills-lock.json) is read-only; overrides go inCLAUDE.md. Plumber-specific skills scaffold viaskills init..claude/rules/backend.md: add unit tests for new code; prefer REST over new root GraphQL fields.Review notes
~12k LoC of the diff is vendored skill content — focus on
CLAUDE.md,rules/backend.md, thepackage.jsonchanges, and theskills-lock.jsonfiles. Engineers needskills.shinstalled globally.