Open
Conversation
Contributor
Author
|
This is a prerequisite to AA support, because with the min SDK version bumped to 23 (Android 6) the current code doesn't build anymore. I also noticed the race condition issues quite a lot during AA development. |
maniac103
force-pushed
the
conn-factory-refactor
branch
from
9e8b2a9 to
7d66db1
Compare
The previous design had 3 main disadvantages: - State getters were racy, since connection and information flags could not be fetched atomically - The callback based design doesn't play really nicely with coroutines - ConflatedBroadcastChannel is deprecated Replace the callback based listener logic as well as the 'wait for initialization' logic by Flows, and design the main flow so that it returns the needed data at once. Signed-off-by: Danny Baumann <dannybaumann@web.de>
maniac103
force-pushed
the
conn-factory-refactor
branch
from
7d66db1 to
62c6c84
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous design had 3 main disadvantages:
Replace the callback based listener logic as well as the 'wait for initialization' logic by Flows, and design the main flow so that it returns the needed data at once.