Skip to content

fix: remove enforced update notice mechanism#363

Open
pgfeller wants to merge 2 commits into
openhab:mainfrom
pgfeller:pgfeller/issue362
Open

fix: remove enforced update notice mechanism#363
pgfeller wants to merge 2 commits into
openhab:mainfrom
pgfeller:pgfeller/issue362

Conversation

@pgfeller
Copy link
Copy Markdown
Contributor

Summary

Closes #362

The MigrationManager.updateCheck() call on every extension activation automatically showed the UpdateNoticePanel webview whenever the extension version changed. This constituted an "enforced" update notice that VS Code surfaces as "Automatic updates enforced by extension author", and also prevented testing pre-release .vsix files because any version change triggered the panel.

Changes

  • Remove MigrationManager.updateCheck(context) call from activate() in extension.ts
  • Remove the openhab.updateNotice command registration and UpdateNoticePanel import from extension.ts
  • Remove the openhab.updateNotice entry from contributes.commands in package.json

Note: MigrationManager.ts and UpdateNoticePanel.ts are now dead code. They can be deleted in a follow-up cleanup PR.

Remove the automatic UpdateNoticePanel that popped up on every
version change and the openhab.updateNotice command entirely.

- Remove MigrationManager.updateCheck() call from activate()
- Remove openhab.updateNotice command registration and UpdateNoticePanel
  import from extension.ts
- Remove openhab.updateNotice entry from contributes.commands in
  package.json

The MigrationManager and UpdateNoticePanel source files are now dead
code and can be removed in a follow-up cleanup.

Closes openhab#362

Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
Copilot AI review requested due to automatic review settings May 16, 2026 02:03
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the update-notice activation path so extension version changes no longer automatically open the update notice webview, aligning with issue #362’s goal of avoiding enforced update prompts during local/pre-release testing.

Changes:

  • Removed the openhab.updateNotice command contribution.
  • Removed update notice command registration and activation-time migration/update check.
  • Performed small let to const cleanups in extension.ts.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
package.json Removes the contributed update notice command from VS Code command metadata.
client/src/extension.ts Removes update notice imports, command registration, and activation-time update check.

@pgfeller pgfeller self-assigned this May 16, 2026
@pgfeller pgfeller requested a review from a team May 16, 2026 02:08
@pgfeller pgfeller added this to the 1.0.1 milestone May 16, 2026
@pgfeller pgfeller requested a review from florian-h05 May 16, 2026 02:55
@florian-h05
Copy link
Copy Markdown

Just to clarify: Does this remove automatic upgraded or only a notice after such?

@pgfeller
Copy link
Copy Markdown
Contributor Author

At the moment you do not have control if and when the extension updates. If you for example install a local test version from .vsix file, vscode will replace it with the marketplace version automatically when you restart the app. That's a hassle to test - and in case you have a broken release you would not be able to select the previous release in the vscode marketplace. It would always use the latest (the settings of vscode do not prevent this).

Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Do not enforce automatic update of the extension

3 participants