fix: remove enforced update notice mechanism#363
Conversation
Remove the automatic UpdateNoticePanel that popped up on every version change and the openhab.updateNotice command entirely. - Remove MigrationManager.updateCheck() call from activate() - Remove openhab.updateNotice command registration and UpdateNoticePanel import from extension.ts - Remove openhab.updateNotice entry from contributes.commands in package.json The MigrationManager and UpdateNoticePanel source files are now dead code and can be removed in a follow-up cleanup. Closes openhab#362 Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
There was a problem hiding this comment.
Pull request overview
This PR removes the update-notice activation path so extension version changes no longer automatically open the update notice webview, aligning with issue #362’s goal of avoiding enforced update prompts during local/pre-release testing.
Changes:
- Removed the
openhab.updateNoticecommand contribution. - Removed update notice command registration and activation-time migration/update check.
- Performed small
lettoconstcleanups inextension.ts.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
package.json |
Removes the contributed update notice command from VS Code command metadata. |
client/src/extension.ts |
Removes update notice imports, command registration, and activation-time update check. |
|
Just to clarify: Does this remove automatic upgraded or only a notice after such? |
|
At the moment you do not have control if and when the extension updates. If you for example install a local test version from .vsix file, vscode will replace it with the marketplace version automatically when you restart the app. That's a hassle to test - and in case you have a broken release you would not be able to select the previous release in the vscode marketplace. It would always use the latest (the settings of vscode do not prevent this). |
Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
Summary
Closes #362
The
MigrationManager.updateCheck()call on every extension activation automatically showed theUpdateNoticePanelwebview whenever the extension version changed. This constituted an "enforced" update notice that VS Code surfaces as "Automatic updates enforced by extension author", and also prevented testing pre-release.vsixfiles because any version change triggered the panel.Changes
MigrationManager.updateCheck(context)call fromactivate()inextension.tsopenhab.updateNoticecommand registration andUpdateNoticePanelimport fromextension.tsopenhab.updateNoticeentry fromcontributes.commandsinpackage.json