Repository navigation
Conversation
wakemeup0
changed the base branch from
main
to
fix/smoke-csharp-s2178-operand-message-20261015
October 15, 2026 19:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Correct 20 captured supplemental C# S2178 parenthesized operand gaps. Preserve short wording for parenthesized identifiers and unknown logical facts; use runtime advice only for two direct explicitly witnessed Boolean identifiers.
Change type and scope
Bug fix for csharpsquid:S2178. Changes are limited to the private rule and its existing actual CLI regression target. Parentheses are checked within 64 visits; casts, comments, malformed wrappers and exhausted depth are refused. Existing bare shapes and binding/call guards are retained.
Related issues
Direct smoke-campaign request to fix findings and publish; no standalone issue or closure is claimed. Depends on published PR947 at
c544670f99cceb193dcda152d903ac1881fa87f9.Verification
Independent source and frozen-evidence review approved this exact signed head without actionable findings. The review verified signed source inventories, unchanged committed regression bytes, executed behavioral red/green evidence, complete ordered report comparisons and fresh CLI witnesses. Independent review receipt SHA256:
ae913bb6d417188ea4d06386855417f5671c8063cf8ebc7892cf99f296924c02. All 21 exact-head hosted checks and dependency-base restoration remain publication gates.Signed unchanged-production tests-only
2e68aa503ef7a4131c5a2658b52be37036206980produced genuine compiled unit and actual CLI assertion failures (both exit 101). Identical test bytes pass at signed final33106d24ef90aee25baa57be809a946bdcec6a78.csharp_s2178_cli_complete_typed_lfandcsharp_s2178_cli_complete_typed_unicode_crlf: all 20 captured reference instances across both layouts, full target objects and whole documents.s2178_parenthesized_*_full_objectsandcsharp_s2178_cli_parenthesized_complete_native_*: both operators, left, right and nested wrappers, mixed logical Unknown/refusal, nearest callable, condition contexts, comments/errors and exact 64-visit and fact-depth boundaries.csharp_s2178_cli_parenthesized_malformed_documents: full diagnostics/incomplete exit 2 preserved.csharp_s2178_cli_logical_cache_runtime_mixed_restored_documents: same path/cache runtime-to-mixed-to-restored documents with source bytes checked around every call.cargo test --locked --jobs 1 -p hoonarqube-csharp --all-targets --all-features -- --test-threads=2: 1905 passed.Local evidence: /Users/wakemeup/.codex/artifacts/hoonarqube-repairs-20261013/csharp-s2178-parenthesized-operands. Exact test-symbol map:
acceptance-to-test-symbols.json; captured command, exit, stdout and stderr receipts:runs/; immutable final binary binding:final-binary-binding.json. Independent root review completed before publication. All 21 exact-head hosted checks and intended dependency-base restoration remain publication gates.The PR initially targeted
mainto obtain all 21 successful checks from the repository’s GitHub default CodeQL setup. The intended dependency base is now restored tofix/smoke-csharp-s2178-operand-message-20261015. Publication verifies the unchanged signed head, full body and exact-head hosted check rollup against that base.Compatibility and risks
Each typed layout now has 151 issues / 44 S2178 targets / 22 long, 22 short; all 260 existing native target objects and their order are retained. Added logical facts are restricted to direct Boolean identifier pairs or valid literal pairs; all mixed, wrapped, nested, call, comparison and unary logical children remain Unknown/short. Original RHS fact depth is retained. The existing native-only parenthesized comparison gains one long finding per layout; this is a native consequence without exact-source reference capture. Catalog, profiles, parser, cache, quickfix and suppression behavior are unchanged.
Limitations
Captured reference is SonarAnalyzer.CSharp 10.33.0.0 (MVID d48c9fe2-34cd-423f-9779-cb2b06ac7d54). No new server/reference run or original project detection repair is claimed. New native controls do not establish additional reference parity. Standalone C# semantic context remains missing/incomplete. The two actual cast-shaped native selections remain absent; this is native parser refusal, not reference parity or clean semantic proof. Full S2178, SonarQube, Enterprise or security parity is unclaimed. Publication and all 21 hosted checks belong to root; no merge, tag or release is requested by this package.