Repository navigation
Conversation
wakemeup0
changed the base branch from
main
to
fix/smoke-go-s107-supporting-locations-20261015
October 15, 2026 19:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Compose existing signed Go repairs PR878 (S1764 operand diagnostics) and PR884 (S126 independent chains and terminal branches) onto accepted PR948. Retain both original signed histories through two automatic signed merges. Final head
c130ad71f2fc9e0578726a6444186441bb941e14, treec6b687c7be604973a7a786d7c2beabd9d62a3b07.One signed snapshot-only update adds the independently qualified nested-chain S126 finding to the two existing S134 CLI complete-document constants. Root reviewed the exact raw reference/source and granted that test surface. Fixtures, functions and assertions remain byte-identical; no additional detector implementation is introduced.
Change type and scope
Dependency composition and regression expectation maintenance. Changes relative to PR948 are confined to
crates/hoonarqube-go/src/lib.rs, inheritedcrates/hoonarqube-go/src/s126_tests.rs, and the two constant payloads incrates/hoonarqube-cli/tests/go_s134_supporting_locations.rs.The imported added/removed lines exactly equal the original PR878/PR884 patches in original order, with no merge conflicts. Parser, cache, IR, exporter, profile, catalog, lockfile, dependencies and public helper contracts are unchanged.
Related issues
Related to PR878, PR884 and PR948 and the user's real OSS/SonarQube smoke campaign. This integrates already published repair histories; it does not create duplicate detector fixes or claim global acceptance/closure. No issue-closing declaration is made.
Verification
Independent source and frozen-evidence review approved this exact signed head without actionable findings. The final review performed 13,225 checks, recomputed both automatic inherited merge trees, verified signed physical source inventories and the exact two authorized test constant payloads, qualified all 21 complete ordered reports and the original regression provenance, and checked 12 fresh independent combined CLI/cache documents. Independent review receipt SHA256:
10973ee7840965194621f982194c5970ea7f28b63375b59b708c082d14348bee. All 21 exact-head hosted checks and intended dependency-base restoration remain publication gates.At the exact clean signed final head:
cargo clippy --locked -p hoonarqube-go -p hoonarqube-cli --all-targets --all-features -- -D warnings.s126_tests/S126 regressions, 4 S1764 regressions and 16 S107 regressions.go_s107_supporting_locations8,go_s1110_supporting_locations6,go_s134_supporting_locations2 andgo_s3776_project_context5.cargo build --locked -p hoonarqube-cli --bin hoonarqube --message-format json-render-diagnosticspassed. Actual immutablebin/hoonarqube, SHA-256114805230f6a746e374bc4461b78c8d6479506c294a2d4d97b1b372e6d9bf5d9.rust:S3776, 4,334 total findings, 1,548 inputs, exit 0, no baseline/waiver. Dedicated Cargo target/jobs=1; no whole workspace sweep.Original red/green proof is inherited honestly. PR878 has actual retained 2-fail/2-pass red and 4-pass green logs, plus signed final test source; it has no separate signed tests-only red commit. PR884 has signed tests-only red
40bcec74c65e8a31874551fcfefcd1d150d33432with 5 fail/4 pass and green 9. Every inherited regression executes in the composed 165-test suite.The genuine initial composition CLI failures are retained: only the two old S134 whole-document constants lacked the measured extra S126/Generic descriptor. Their actual outputs equal the boundary expectation frozen before candidate evaluation; removing solely that issue/descriptor restores the original whole objects. Independent root review authorized the exact constants-only update, followed by green 2 at this head. The other 19 CLI tests pass in the retained initial invocations.
Frozen expected v1 is preserved. Before candidate 21 replay, separately frozen r2 corrects only adjacent Generic S1764/S1125 ordering (5:27 before 5:28); complete multiset/all object fields, 20 other stdout documents and all 21 stderr documents remain identical. Setup/verifier failures are retained separately and do not count as detector-red proof.
Evidence package:
go-original-dependency-composition, includingREPORT.md,qualification.json,artifact-manifest.json,receipt.json,issue-test-symbol-mapping.json,binary.json,complete-replay-results.jsonand complete reference/actual objects. Worker local gates/evidence are complete; hosted publication checks and intended-base restoration remain coordinator-owned and are not claimed here.The PR initially targeted
mainto obtain all 21 successful checks from the repository’s GitHub default CodeQL setup. The intended dependency base is now restored tofix/smoke-go-s107-supporting-locations-20261015. Publication verifies the unchanged signed head, full body and exact-head hosted check rollup against that base.Compatibility and risks
Only existing measured S126/S1764 behavior is imported. All S134 and unrelated boundary fields remain unchanged after stripping the single measured S126/used descriptor. The raw reference's absent supporting
msgand native/Generic explicit empty support message remain distinguished.Reference data is retained from real SonarQube Community 26.9.0.129388 with Go 1.43.0.7704, plugin JAR SHA-256
8b32b9cdf3088751cdd53f6607ba720cf10a0d1b1dce9fb1a2a6b548ece9f810. Original server147B411E-AaE1_Y_veHHAmXIblqyUand recovered live-control server147B411E-AaE3EAuNgNIW5ireOyxLremain separate. Exact sources/profiles and threshold 15 are retained; original strict reports preserve absent top-level parity metadata. This package performs no new reference scan.Limitations
The evidence qualifies only the listed measured OSS/control scopes. S1764 is unexercised on the original OSS pair. There is no whole-rule or global SonarQube parity claim. Separate S107 residuals remain: variadic omission, literal primary range, non-BMP coordinate, Max2 configuration mismatch, absent-versus-empty support messages, S1451 configuration and broader unprobed shapes. Source composition and local green checks do not establish a merge/release or the coordinator's hosted endpoint.