[XIF] Making the XIF ID unique - #992
Open
Joao-Pedro-Cabral wants to merge 1 commit into
Open
Joao-Pedro-Cabral wants to merge 1 commit into
Joao-Pedro-Cabral wants to merge 1 commit into
Conversation
Author
|
Sorry, can you help me with the ECA, I've never used this type of tool :/ ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As stated on the file
cv32e40x_if_stage.svon the commit52c86ae0c95cadd005fae3f8c7425a72d0687d0c:// TODO:XIF assert that the oustanding IDs are unique
And in my personal setup I got situations where the outstanding IDs are not unique.
This behavior can happens if in one cycle the ID offloads a instruction via XIF, then
xif_offloading_id_iturns on.However, it is possible for the ID stage updates its content to the next instruction, while the IF is stalled. In this situation,
xif_offloading_id_iwill be turned off before the IF stage ready to increment thexif_idregister.My solution is very simple, basically buffering the
xif_offloading_id_isignal if the IF stage is not ready, and clearing it when IF is ready.