Conversation
added missing finish relation level argument '1' to the $fatal task inside cve2_top_tracing.sv to ensure compliance with modern industrial EDA compilers.
|
Hi @ANDAL7, thanks for your interest in OpenHW and your PR to the CVE2. Before we can accept it, you must be covered by the ECA. Please review CONTRIBUTING for the details. |
|
@davideschiavone @MikeOpenHWGroup This PR is a duplicate of #334, which has been merged. |
You are right @cairo-caplan, thanks for pointing this out. Hi @ANDAL7, since you haven't responded to our request to sign the ECA, and the issue you flag has been resolved by #334, I am closing this PR. Please feel free to open other Issues or PRs, and keep in mind we require a signed ECA before we can merge your PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added missing finish relation level argument '1' to the $fatal task inside cve2_top_tracing.sv to ensure compliance with modern industrial EDA compilers.