RISC-V: Fix XCVALU extension patterns#114
Open
gtagliavini wants to merge 1 commit into
Open
Conversation
Remove redundant truncate operations from the XCVALU sign- and zero-extension patterns. The input operands already have the proper QI or HI mode, so the truncate expressions are unnecessary and make the RTL pattern less canonical. Also prevent the generic SI sign-extension split from being used for XCVALU on RV32, where dedicated cv.ext* instructions are available. gcc/ChangeLog: * config/riscv/riscv.md (riscv_cv_alu_exths): Remove redundant truncate. (riscv_cv_alu_exthz): Likewise. (riscv_cv_alu_extbs): Likewise. (riscv_cv_alu_extbz): Likewise. (*extend<SHORT:mode><SUPERQI:mode>2): Disable split for XCVALU on RV32.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove redundant truncate operations from the XCVALU sign- and zero-extension patterns. The input operands already have the proper QI or HI mode, so the truncate expressions are unnecessary and make the RTL pattern less canonical.
Also prevent the generic SI sign-extension split from being used for XCVALU on RV32, where dedicated cv.ext* instructions are available.
gcc/ChangeLog:
Thanks for taking the time to contribute to GCC! Please be advised that if you are
viewing this on
github.com, that the mirror there is unofficial and unmonitored.The GCC community does not use
github.comfor their contributions. Instead, we usea mailing list (
gcc-patches@gcc.gnu.org) for code submissions, code reviews, andbug reports. Please send patches there instead.