Fixed parameter overflow in divsqrt_multi#106
Open
sifferman wants to merge 1 commit intoopenhwgroup:developfrom
Open
Fixed parameter overflow in divsqrt_multi#106sifferman wants to merge 1 commit intoopenhwgroup:developfrom
sifferman wants to merge 1 commit intoopenhwgroup:developfrom
Conversation
pascalgouedo
approved these changes
Jan 18, 2024
pascalgouedo
left a comment
pascalgouedo
left a comment
There was a problem hiding this comment.
PULP DIV/SQRT not used in CV32E40P.
Letting people using it approve it or not...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
Issue
Commits 51e6ba8 and 1548dae from PR #102 have introduced a bug due to the use of
NUM_INP_REGS-1without checkingNUM_INP_REGS > 0.This causes the basic instantiation example to fail in DC due to
Error: fpnew_divsqrt_multi.sv: integer overflow occurs. (ELAB-210).Fix
I now split all 3 references to
reg_ena_i[NUM_INP_REGS-1]into a new signallast_reg_enathat is forced to1'b0ifNUM_INP_REGS==0.Now the basic instantiation example once again is synthesizable.
Thanks!