2762: Prevent individual external PR failures from blocking IssueBot processing - #1781
Open
zhaosongzs wants to merge 1 commit into
Open
2762: Prevent individual external PR failures from blocking IssueBot processing#1781zhaosongzs wants to merge 1 commit into
zhaosongzs wants to merge 1 commit into
Conversation
|
👋 Welcome back zsong! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IssueBot previously processed all PRs associated with an updated issue through a single stream. If fetching any one external PR failed, the exception terminated the whole stream. Therefore, valid PRs were not processed and no CheckWorkItems were created for them. The periodic batch also did not complete normally.
We should process each associated PR independently instead. When a PR query fails, log the failure and schedule the issue for retry in a later polling round. Continue creating CheckWorkItems for the remaining PRs in the current round, so a transient or broken external PR cannot block unrelated valid PRs.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/skara.git pull/1781/head:pull/1781$ git checkout pull/1781Update a local copy of the PR:
$ git checkout pull/1781$ git pull https://git.openjdk.org/skara.git pull/1781/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1781View PR using the GUI difftool:
$ git pr show -t 1781Using diff file
Download this PR as a diff file:
https://git.openjdk.org/skara/pull/1781.diff
Using Webrev
Link to Webrev Comment