Skip to content

2762: Prevent individual external PR failures from blocking IssueBot processing - #1781

Open
zhaosongzs wants to merge 1 commit into
openjdk:masterfrom
zhaosongzs:SKARA-2762
Open

2762: Prevent individual external PR failures from blocking IssueBot processing#1781
zhaosongzs wants to merge 1 commit into
openjdk:masterfrom
zhaosongzs:SKARA-2762

Conversation

@zhaosongzs

@zhaosongzs zhaosongzs commented Jul 10, 2026

Copy link
Copy Markdown
Member

IssueBot previously processed all PRs associated with an updated issue through a single stream. If fetching any one external PR failed, the exception terminated the whole stream. Therefore, valid PRs were not processed and no CheckWorkItems were created for them. The periodic batch also did not complete normally.

We should process each associated PR independently instead. When a PR query fails, log the failure and schedule the issue for retry in a later polling round. Continue creating CheckWorkItems for the remaining PRs in the current round, so a transient or broken external PR cannot block unrelated valid PRs.



Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace

Issue

  • SKARA-2762: Prevent individual external PR failures from blocking IssueBot processing (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/skara.git pull/1781/head:pull/1781
$ git checkout pull/1781

Update a local copy of the PR:
$ git checkout pull/1781
$ git pull https://git.openjdk.org/skara.git pull/1781/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1781

View PR using the GUI difftool:
$ git pr show -t 1781

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/skara/pull/1781.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented Jul 10, 2026

Copy link
Copy Markdown

👋 Welcome back zsong! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Jul 10, 2026

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot changed the title SKARA-2762 2762: Prevent individual external PR failures from blocking IssueBot processing Jul 10, 2026
@openjdk openjdk Bot added the rfr Pull request is ready for review label Jul 10, 2026
@mlbridge

mlbridge Bot commented Jul 10, 2026

Copy link
Copy Markdown

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant