fix(container): activate podman socket on Linux when not running#1610
fix(container): activate podman socket on Linux when not running#1610bmahabirbu wants to merge 1 commit into
Conversation
On Linux, the podman API socket is not always active — it requires systemd socket activation or an explicit service start. This matches Podman Desktop's behavior by spawning `podman system service --time=0` when the socket is missing, waiting up to 5s for it to appear, and killing the process on extension deactivation. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Brian <bmahabir@bu.edu>
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This was needed because on linux it couldnt find the ramalama services because of this |
|
relates to #1602 |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
| let args = ['system', 'service', '--time=0']; | ||
| if (process.env.FLATPAK_ID) { | ||
| command = 'flatpak-spawn'; | ||
| args = ['--host', 'podman', ...args]; |
There was a problem hiding this comment.
praise: should use exec from the extension API
|
@jeffmaury I noticed that in podman-desktop the socket opens and closes automatically on linux so thought id just try to add the functionality in kaiden too |
|
so I know in Podman Desktop we start the service but users are complaining that sometimes they have the service already started so there are like 2 servers then |
benoitf
left a comment
There was a problem hiding this comment.
overall I'm ok as it simplifies the default experience but as @jeffmaury said, it needs to use the exec API
MarsKubeX
left a comment
There was a problem hiding this comment.
Looks good in general but same comment as the others, use exec from the api extension
|
@bmahabirbu are you planning to fix this ? or we put the label 'on hold' |
|
setting to draft as I didn't get a reply |
Summary
PodmanSocketLinuxFinderto spawnpodman system service --time=0when the rootless socket is missing, matching Podman Desktop's behavior@preDestroy()disposeflatpak-spawn --host)Test plan
🤖 Generated with Claude Code