Skip to content

Fix gosec warnings#587

Open
denverdino wants to merge 2 commits into
openkruise:masterfrom
denverdino:master
Open

Fix gosec warnings#587
denverdino wants to merge 2 commits into
openkruise:masterfrom
denverdino:master

Conversation

@denverdino

Copy link
Copy Markdown

Fix gosec warnings

The first commit contains the code fix.
The second commit suppresses a false positive.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

@kruise-bot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zmberg for approval by writing /assign @zmberg in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot

Copy link
Copy Markdown

Welcome @denverdino! It looks like this is your first PR to openkruise/agents 🎉

@codecov

codecov Bot commented Jun 29, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 68.18182% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.84%. Comparing base (6205b42) to head (2a42082).

Files with missing lines Patch % Lines
.../utils/webhookutils/writer/atomic/atomic_writer.go 0.00% 9 Missing ⚠️
pkg/webhook/webhook_controller.go 0.00% 3 Missing ⚠️
pkg/agent-runtime/storage-cli/main.go 88.88% 1 Missing ⚠️
pkg/controller/sandboxset/revision.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #587   +/-   ##
=======================================
  Coverage   79.84%   79.84%           
=======================================
  Files         202      202           
  Lines       14795    14795           
=======================================
  Hits        11813    11813           
  Misses       2552     2552           
  Partials      430      430           
Flag Coverage Δ
unittests 79.84% <68.18%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants