Skip to content

Do your best to clean up the upgrade state when finish, otherwise, it may affect the next upgrade.#331

Open
gaopeiliang wants to merge 1 commit into
openkruise:masterfrom
gaopeiliang:master
Open

Do your best to clean up the upgrade state when finish, otherwise, it may affect the next upgrade.#331
gaopeiliang wants to merge 1 commit into
openkruise:masterfrom
gaopeiliang:master

Conversation

@gaopeiliang

@gaopeiliang gaopeiliang commented Mar 17, 2026

Copy link
Copy Markdown

#330

when use karmada sync deployment ; batch release controller should clear up rolling strategy when finish ;;

But it maybe ignore this because karmada sync always and webhook not hook "spec.paused" field;; it will affect next upgrade;

So the conditions for cleaning up the state after the upgrade should be more relaxed.

otherwise, it may affect the next upgrade.
@kruise-bot kruise-bot requested review from FillZpp and veophi March 17, 2026 13:05
@kruise-bot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zmberg for approval by writing /assign @zmberg in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot

Copy link
Copy Markdown

Welcome @gaopeiliang! It looks like this is your first PR to openkruise/rollouts 🎉

@codecov

codecov Bot commented Mar 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.38%. Comparing base (8416512) to head (6d7c63a).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #331   +/-   ##
=======================================
  Coverage   51.38%   51.38%           
=======================================
  Files          66       66           
  Lines        8559     8559           
=======================================
  Hits         4398     4398           
  Misses       3575     3575           
  Partials      586      586           
Flag Coverage Δ
unittests 51.38% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants