Repository navigation
(#271) [v0.10] Fix(bench): reject non 2xx GET responses - #286
Merged
Merged
Conversation
Reject unsuccessful benchmark GET responses and include the HTTP status in the error before validating the response body length. Existing worker error propagation prevents failed batches from updating benchmark counters. Add HTTP/2 regression tests for successful and size-matched error responses. Fixes #271. Based on #278 by AayushPratapBansal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reject unsuccessful benchmark GET responses and include the HTTP status in the error before validating the response body length. Existing worker error propagation prevents failed batches from updating benchmark counters.
Add HTTP/2 regression tests for successful and size-matched error responses.
Fixes #271.