Skip to content

fix(bench): reject sizes that overflow byte conversion - #291

Merged
ArnavBalyan merged 1 commit into
mainfrom
arnavb/fix-large-val
Sep 24, 2026
Merged

ArnavBalyan merged 1 commit into
mainfrom
arnavb/fix-large-val

Conversation

@ArnavBalyan

Copy link
Copy Markdown
Contributor
  • Replace unchecked multiplication with checked_mul in the shared size parser.
  • Return a clear error when a size exceeds the supported byte count.
  • Add regression tests for overflowing inputs, maximum valid sizes and normal unit parsing.

@the-company-company the-company-company Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No issues found

Reviewed commit bd2892c.

@ArnavBalyan
ArnavBalyan merged commit e4e85da into main Sep 24, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant