Add support for storing multiple signing keys in different YK slots - #759
Merged
Conversation
Let setup-signing-key/setup-test-key target any PIV slot instead of always hardcoding SIGNATURE, add a list-slots command to see what's free/occupied, and make get-roles check every occupied slot
_slot_occupied only checked for a certificate, missing a slot that holds a key without one (e.g. an interrupted setup(), or a slot provisioned by another tool) - such a slot would be silently overwritten even without --force. Now checks get_slot_metadata first (reflects the key directly), falling back to the certificate check on firmware that doesn't support it (pre-5.3, e.g. YubiKey 4).
…fault Reset-based setup now generates a random management key and stores it in the card's PIN-protected data object
renatav
marked this pull request as ready for review
July 15, 2026 13:31
n-dusan
approved these changes
Jul 17, 2026
n-dusan
left a comment
n-dusan
left a comment
Contributor
There was a problem hiding this comment.
looks good. tests were very helpful for the review, thanks.
let's add a changelog entry. do we need to update the platform following these changes?
Collaborator
Author
|
@n-dusan I don't think we need to update platform, but let's not merge this is until we've released other TAF fixes |
Collaborator
Author
|
Turns out no urgent TAF fixes are necessary. I've updated them Changelog and will merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (e.g. "Related to ...", etc.)
See #758
Code review checklist (for code reviewer to complete)