Skip to content

fix: _setup_yubikey must actually reset when generating a new key #760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
renatav merged 1 commit into from
Jul 21, 2026
Merged

fix: _setup_yubikey must actually reset when generating a new key #760

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion taf/keys.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -655,8 +655,17 @@ def _setup_yubikey(
if yubikeys is not None:
key, serial_num, key_name = yubikeys[0]
if not use_existing:
# TODO: always resetting is temporary - once signing supports
# slots other than SIGNATURE, let the user pick which slot to
# use here (default SIGNATURE), and only overwrite it (force,
# non-destructive to the rest of the card) instead of ever
# doing a full reset
key = yk.setup_new_yubikey(
auth_repo.pin_manager, serial_num, scheme, key_size=key_size
auth_repo.pin_manager,
serial_num,
scheme,
key_size=key_size,
reset=True,
)

if certs_dir is not None:
Expand Down
Loading