Fix macOS DMG bundle signing - #9
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
identity: "-")codesignchecks before uploading any workflow artifact or GitHub Release assetRoot cause
The published DMG itself had a valid checksum, but the app inside was not a valid signed bundle. Electron Mach-O files retained linker-generated ad-hoc signatures while the app had no
_CodeSignature/CodeResourcesresource seal.codesign --verify --deep --strictfailed withcode has no resources but signature indicates they must be present, which macOS surfaces as a damaged app.Impact
New DMGs contain a structurally valid ad-hoc signed app instead of a malformed partially signed bundle. This removes the damaged-package failure without requiring an Apple Developer certificate. The build remains unnotarized, so macOS may still show the normal unidentified-developer warning.
Validation
hdiutil verifyboth confirmed the DMG transport was intactcodesign --verify --deep --strict --verbose=4pnpm run typecheckpnpm run test:ci(148 tests)node --test scripts/*.test.mjs(26 tests)