[BUG] Fix Sklearn Models detection by safely importing openml-sklearn #1556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geetu040
suggested changes
Dec 25, 2025
geetu040
left a comment
geetu040
left a comment
There was a problem hiding this comment.
Nice, the safe import logic looks good.
Since this is specific to models and flows I would suggest we move it inside both functions in extensions/functions.py as you suggested before. Though it's still not the best place to put this, but we are restricted by circular imports and can improve the logic afterwards when extension classes are refactored
Also, could you improve the SKLEARN_HINT message, you can suggest to install it using pip install openml-sklearn
geetu040
suggested changes
Dec 26, 2025
| "For more information, see " | ||
| "https://github.com/openml/openml-sklearn?tab=readme-ov-file#installation" | ||
| "You can use `pip install openml-sklearn` for installation." | ||
| ) |
There was a problem hiding this comment.
Keep the "for more information" lines at the very end. Perhaps we can refer to one of the following links for more information
I would prefer the second link, but let me know if you think otherwise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Metadata
Details
Fixed sklearn models detection by safely importing openml-sklearn at
openml/runs/__init__.py