Skip to content

Document MonteCarloBarostat behavior with periodic ML potentials? #91

Description

@jchodera

While MonteCarloBarostat is a molecular-scaling barostat, my understanding is that findMolecules() will put every atom into a separate molecule if only a periodic ML potential is defined (such as the MACE-OFF23 as periodic potential), effectively performing as an atomic-scaling barostat. This would be the desired behavior, since waters may exchange protons and continuing to use the wrong molecule definitions would degrade barostat efficiency significantly.

I'm just wondering if we want to document this somewhere (here in the README? in the User Guide?) since this was non-trivial to figure out by looking through the implementations.

cc @saratk1

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions