Skip to content

Add legacy-cgi to replace cgi#338

Merged
epretti merged 2 commits intoopenmm:masterfrom
epretti:legacy-cgi
Sep 22, 2025
Merged

Add legacy-cgi to replace cgi#338
epretti merged 2 commits intoopenmm:masterfrom
epretti:legacy-cgi

Conversation

@epretti
Copy link
Member

@epretti epretti commented Sep 22, 2025

Adds the legacy-cgi package to replace the deprecated cgi module that is gone from Python 3.13. Resolves #318.

Does devtools/conda-recipe/meta.yaml need to be updated too? This looks old and outdated compared to the meta.yaml in conda-forge/pdbfixer-feedstock so I assume it's not being used currently?

@peastman
Copy link
Member

We should only add it to install_requires when installing on Python 3.13 or later.

Yes, we'll need to update the conda recipe as well. I'll be doing an updated release soon, so I'll make the change as part of building the release.

@peastman
Copy link
Member

Oh, sorry, you mean the one in this repo. Correct, that's obsolete.

@epretti
Copy link
Member Author

epretti commented Sep 22, 2025

Are .travis.yml and devtools/travis-ci also obsolete? If so, I could remove them (probably in a separate PR) with the devtools/conda-recipe that is in this repository.

@peastman
Copy link
Member

peastman commented Sep 22, 2025

Yes, we haven't used travis in a long time.

This looks good to merge.

@epretti epretti merged commit 6a3f61d into openmm:master Sep 22, 2025
3 checks passed
@epretti epretti deleted the legacy-cgi branch September 22, 2025 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove use of cgi module

2 participants