(chore) Normalize ampathforms filenames#67
Merged
denniskigen merged 1 commit intoApr 24, 2026
Conversation
Rename form and translation files under configuration/backend_configuration/ampathforms/ and ampathformstranslations/ to consistent snake_case, apply the -core_demo package suffix uniformly, and fix the "stuctured" → "structured" typo. Internal form names and UUIDs are not changed, so runtime form lookup and translation binding (which use the form's internal `name` field) are unaffected.
ibacher
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rename form and translation files under
configuration/backend_configuration/ampathforms/andconfiguration/backend_configuration/ampathformstranslations/to a consistent shape:-core_demopackage suffix applied uniformly (was previously on 5 of 8 forms)stuctured_soap_note→structured_soap_noteRenames
ampathforms/Mental Health Assessment Form.jsonmental_health_assessment_form-core_demo.jsonTestResultsEntryFormv2-core_demo.jsontest_results_entry_form_v2-core_demo.jsonipd_admission_request.jsonipd_admission_request-core_demo.jsonstuctured_soap_note.jsonstructured_soap_note-core_demo.jsontest-form-core_demo.jsontest_form-core_demo.jsonampathformstranslations/Test Form 1_translations_fr-core_demo.jsontest_form_1_translations_fr-core_demo.jsonsoap_note_translations_en.jsonsoap_note_translations_en-core_demo.jsonsoap_note_translations_fr.jsonsoap_note_translations_fr-core_demo.jsonSafety
No content changes. Internal
nameanduuidfields inside each JSON are untouched, so:openmrs-esm-form-engine-lib) looks up forms by UUID or internalnamevia/ws/rest/v1/form/...— filename is not consulted.formname field, not filename.addresshierarchydomain, cf. ADDR-138: Rename addressConfiguration-core_demo.xml to addressConfiguration.xml #7).Note on the translation filename
test_form_1_translations_fr-core_demo.json: its internalformfield is"Test Form 1", which matches the internalnameoftest_form-core_demo.json. The filenames differ only in the trailing_1, which is cosmetic — binding is by internal name.Out of scope
-core_demosuffix repo-wide (decision with cross-package implications, ref. discussion in ADDR-138: Rename addressConfiguration-core_demo.xml to addressConfiguration.xml #7).soap_note_template-core_demo.jsonandstructured_soap_note-core_demo.json— not addressed here.