fix: batch Resume UI layer installation - #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setEditorComponentwrite per TUI sessionWhy
Pi owns
/resume: it clears extension UI, replaces the Session runtime, and emitssession_startfor the new runtime. The old PR #13 tried to suppress repeated installs with booleans stored inside each extension instance, but those booleans reset on Resume. Its task guard could also freeze the first snapshot.This change works with Pi's lifecycle: editor contributors register their layers on the runtime EventBus, one coordinator batches the UI installation after all
session_starthandlers, and shutdown removes only layers that were actually registered.Replaces #13.
Test plan
bun run checkbun run test— 715 Node tests and 29 Vitest testsnpm pack --dry-run --ignore-scripts --json— runtime coordinator included, test excluded