refactor(git-read): use shared search seams - #368
Open
seekskyworld wants to merge 1 commit into
Open
Conversation
Signed-off-by: seekskyworld <djh1813553759@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Implements the cross-extension import slice of #73.
git-readdirectly imported privatefile-search/srcmodules, coupling extension internals.Value
A named shared seam makes the dependency direction explicit and gives future refactors one stable import boundary without changing command, output, or process semantics.
Approach
Add shared re-export seams for bounded search output and process execution, then update
git-readto consume only those shared modules. The underlying implementation and behavior remain unchanged.Validation
npx tsc --noEmitgit diff --checkImpact