-
Notifications
You must be signed in to change notification settings - Fork 45
feat(web): expose read-only terminal session history #397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
testikun
wants to merge
4
commits into
openpi-dev:main
Choose a base branch
from
testikun:codex/issue-347-terminal-history
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+332
−1
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
dcebb07
feat(web): expose read-only terminal session history
testikun 24be07a
Merge upstream/main into codex/issue-347-terminal-history
testikun 75b1f41
test(web): align terminal history fixture with runtime contract
testikun edeb7b3
Merge remote-tracking branch 'upstream/main' into HEAD
testikun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P2] Scope history discovery before reading every workspace transcript
SessionManager.listAll() without a directory enumerates all default Pi workspaces; its buildSessionInfo reads each whole JSONL and retains allMessagesText. Filtering by the current workspace and slicing the page afterward does not bound that work. getReadOnlyTerminalSession at line488 repeats the same scan before the bounded preview loader. Reproduction with one target Session plus ten unrelated workspace Sessions of512KiB each: list(limit=1) and then preview each independently load11 Sessions, including10 unrelated workspaces, and retain5,242,886 message characters while returning only one row/two preview messages. Every page and preview therefore scales with all personal history and has no source-byte/time/cancellation bound. Restrict discovery to the selected workspace before loading transcripts and keep lookup/preview work bounded and cancellable; add coverage proving unrelated workspace files are not parsed for this route.