feat(ui): quieter tool lines and relative paths in subagent transcripts - #54
Merged
Conversation
- Drop the redundant → prefix from tool call lines: the phase glyph (spinner / ✓ / ✗ / ·) already leads the line, so a second marker was noise. Bash keeps its $ prompt form. - Relativize paths inside the child's own checkout, both in tool argument summaries (read/write/edit/rg/fd) and in output previews, which echo the absolute search path back. /Users/…/docs/x.md now reads as docs/x.md; paths outside the checkout stay absolute.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Polish for the takeover view's transcript rendering (the per-tool output display inside a subagent):
✓ → read …— a status glyph stacked on an arrow marker. The arrow carried no information, so it is gone:✓ read docs/x.md,⠸ rg foo,✗ bash …. Bash keeps its$prompt form.read/write/edit/rg/fdpreviews showed absolute paths (/Users/…/my-pi-setup/docs/design/README.md). Paths inside the child's own checkout now render relative (docs/design/README.md); paths outside stay absolute, and a shared-prefix non-boundary (/repo-other) is not mistaken for the cwd.fd/rgecho the absolute search path back in their output, so result lines get the same treatment.Before / after (from a real explorer run):
Verification
bun run checkclean;bun run test: 754 node:test + 29 vitest passingsummarizeToolArgs(boundary cases included) and an end-to-end transcript line assertion