Skip to content

Choice between \MT and \MD on Windows - #89

Merged
vonnieda merged 2 commits into
openpnp:masterfrom
semanux:choice-between-mt-and-md
Nov 11, 2025
Merged

vonnieda merged 2 commits into
openpnp:masterfrom
semanux:choice-between-mt-and-md

Conversation

@raphaelmenges

Copy link
Copy Markdown
Contributor

Hello 👋

My environment, i.e., a Rust project, requires me to link the MSVC runtime dynamically into OpenPNP-Capture on Windows. I suggest to make this behavior optional and controllable via a new LINK_DYNAMIC_MSVC_RUNTIME CMake option.

@vonnieda

Copy link
Copy Markdown
Member

Note: Closed and re-opened to re-run tests.

@vonnieda vonnieda closed this Nov 11, 2025
@vonnieda vonnieda reopened this Nov 11, 2025
@vonnieda
vonnieda merged commit 28b7fd3 into openpnp:master Nov 11, 2025
8 of 10 checks passed
@vonnieda

Copy link
Copy Markdown
Member

Thank you @raphaelmenges!

@raphaelmenges

Copy link
Copy Markdown
Contributor Author

Great @vonnieda!

I just noticed a small mistake on my side in the README_BUILD.md:

  • LINK_DYNAMIC_MSVC_RUNTIME: Link MSVC runtime statically, aka \MD. Otherwise \MT. (default: OFF)

Must be:

  • LINK_DYNAMIC_MSVC_RUNTIME: Link MSVC runtime dynamically, aka \MD. Otherwise \MT. (default: OFF)

Can you just fix it or should I open another PR?

vonnieda added a commit that referenced this pull request Nov 13, 2025
Corrected the description of the LINK_DYNAMIC_MSVC_RUNTIME option to indicate dynamic linking per #89 (comment)
@vonnieda

Copy link
Copy Markdown
Member

Done, thanks @raphaelmenges!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants