Migrate golangcilint#233
Merged
Merged
Conversation
Signed-off-by: Fabian Kammel <fabian@kammel.dev>
Signed-off-by: Fabian Kammel <fabian@kammel.dev>
Signed-off-by: Fabian Kammel <fabian@kammel.dev>
Member
|
No strong feelings about which linters to use as long as they cover roughly the same cases. Below I just did a double check what is default now and it seems like we only lost gosimple. However I don't think that is a big loss as gosimple has been depreciated in favor of staticcheck. previously we had:now: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrated golangci-lint to version 2 as we were already using version 2.x of golangci-lint, to fix pipeline in #122
I migrated the configuration file using the tool assissted approach as per documentation. This leads to some changes, most relevant for us "
run.timeout: the existing value is ignored because, in v2, there is no timeout by default.". I would say we accept this for now, and if the action takes too long we add a timeout there.There have also been changes to the used linters (even though I followed their docs). gosimple for example was available in v1 but vanished in v2.
Do you have strong feelings about the included linters @EthanHeilman ?
Happy to add more in this PR or create an issue to look into this.