Repository navigation
Conversation
The notification and Firebase messaging handling now lives in ORLib (console-ios-lib#21). Forwarding the FCM token to ORLib also fixes the token not reaching the backend until the app is restarted (console-ios-lib#39). Firebase is now configured on every launch. It used to be skipped when the app was started in the background by a location update or a remote notification, so such a process never received an FCM token and set the APNs token on an unconfigured Firebase instance. The removed didRefreshRegistrationToken is no longer part of the Firebase MessagingDelegate protocol and was never called.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on openremote/console-ios-lib#40. Draft until that is released, because the ORLib minimum version in the project still has to be bumped to that release.
Changes
AppDelegateforwardswillPresent,didReceiveanddidReceiveRegistrationTokentoORNotificationHandler. This removes the notification handling that was duplicated across console apps (Move UNUserNotificationCenterDelegate and MessagingDelegate boilerplate into ORLib console-ios-lib#21).didRefreshRegistrationToken. It is no longer part of the FirebaseMessagingDelegateprotocol and never got called.Testing
Builds against the console-ios-lib branch from #40. Not tested on a device yet.
Before merge
Bump the console-ios-lib package requirement to the release containing #40.