You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Add Gateway test for each currently supported Gateway API version #2479
So this issue covers getting the existing tests to work again provided they still make sense, but also to adapt to cover each version of the gateway API that the manager should still support so we can have confidence that any changes maintain this compatibility.
The Gateway API versions are explained in the javadoc here
The idea is to then use JSON strings to represent event classes for old gateway API versions and to simulate the initialisation process for those old event classes. Easiest way to create those JSON strings would be to checkout code at a commit that uses that API version and to then see the payload that gets sent copy these into string variables in the test, repeat this for each API version including the current one.
I've taken a quick look at the code, hoping that I could easily pick this issue up myself.
But for me it would be quite a lot of hassle to get it all set up, and to write tests without proper knowledge of the gateway spec.
I wouldn't like to spend a full week of my time iterating on this, knowing that others like @pankalog would be more suitable.
Unassigning myself from this issue.
(I'll unassign Rich as well as he clarified the issue above)
changed the title [-]Reinstate GatewayTests with a test for each currently supported Gateway API version[/-][+]Add Gateway test for each currently supported Gateway API version[/+]on Mar 17, 2026
Activity
MartinaeyNL commentedon Feb 12, 2026
This needs a bit more context on;
and the other acceptance criteria that belong to this issue.
richturner commentedon Feb 16, 2026
So this issue covers getting the existing tests to work again provided they still make sense, but also to adapt to cover each version of the gateway API that the manager should still support so we can have confidence that any changes maintain this compatibility.
There is already test code that simulates a gateway by sending/receiving the individual events to complete initialisation of the gateway see GatewayTest::Gateway asset provisioning and local manager logic test.
The Gateway API versions are explained in the javadoc here
The idea is to then use JSON strings to represent event classes for old gateway API versions and to simulate the initialisation process for those old event classes. Easiest way to create those JSON strings would be to checkout code at a commit that uses that API version and to then see the payload that gets sent copy these into string variables in the test, repeat this for each API version including the current one.
Each API version should be in its' own test.
richturner commentedon Feb 16, 2026
Happy to discuss on a call for further clarification and pointers
MartinaeyNL commentedon Feb 17, 2026
I've taken a quick look at the code, hoping that I could easily pick this issue up myself.
But for me it would be quite a lot of hassle to get it all set up, and to write tests without proper knowledge of the gateway spec.
I wouldn't like to spend a full week of my time iterating on this, knowing that others like @pankalog would be more suitable.
Unassigning myself from this issue.
(I'll unassign Rich as well as he clarified the issue above)
[-]Reinstate GatewayTests with a test for each currently supported Gateway API version[/-][+]Add Gateway test for each currently supported Gateway API version[/+]richturner commentedon Mar 17, 2026
I have now reinstated the gateway tests and updated this issue accordingly
richturner commentedon Sep 4, 2026
@wborn I've updated my comment above