Repository navigation
[Sparse ANN] Bump neural-sparse-cpp submodule for DiskSeismic madvise fix - #2005
Conversation
…p madvise fix (opensearch-project#55) Signed-off-by: Zirui Song <zrsong@amazon.com>
PR Code Analyzer ❗AI-powered 'Code-Diff-Analyzer' found issues on commit 49c4275. ⛔ Hard block: Issues at High severity or above will block this PR from merging.
The table above displays the top 10 most important findings. Pull Requests Author(s): Please update your Pull Request according to the report above. Repository Maintainer(s): You can Thanks. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2005 +/- ##
=========================================
Coverage 84.20% 84.21%
- Complexity 4239 4241 +2
=========================================
Files 318 318
Lines 14887 14887
Branches 2425 2425
=========================================
+ Hits 12536 12537 +1
Misses 1485 1485
+ Partials 866 865 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
Bump neural-sparse-cpp for the DiskSeismic mmap madvise fix (MADV_RANDOM for per_block), fixing a large memory-constrained latency regression. Details can be seen in: opensearch-project/neural-sparse-cpp#55
This makes the madvise hint a function of the index's access pattern instead of a single global default:
DiskSeismicIndex,DiskSeismicScalarQuantizedIndex) →MADV_RANDOM(point lookups; suppress readahead).shared(SeismicIndex,SeismicScalarQuantizedIndex) →MADV_HUGEPAGE(broad scans; fewer TLB entries), unchanged.NSPARSE_MMAP_ADVISEstill overrides the choice (an empty value is treated as unset, so it can't silently reinstate the old default).Measured impact
From the launch benchmark (i4i.16xlarge, MS MARCO V1, 12 GB page-cache cap, THP=
[madvise], top_n=5, k′=20, recall ≈ 0.92), same index and queries:per_block)per_block)Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.