Repository navigation
DiskSeismic: add python tests & de-dup serialization - #33
Merged
chishui merged 1 commit intoAug 27, 2026
Merged
Conversation
Signed-off-by: Zirui Song <zrsong@amazon.com>
zirui-song-18
requested review from
chishui,
model-collapse and
yuye-aws
as code owners
August 26, 2026 10:07
Collaborator
|
does the index size results in previous PR change much? |
Collaborator
Author
chishui
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addresses the two follow-ups from #32:
DiskSeismicIndexwrote the per-cluster doc-id membership twice — in the posting-list section and as per-block doc ids in the inline forward index — yet the posting-list copy is never read on the mmap search path (doc ids come from the forward index; only the cluster summaries + counts are used).write_indexnow serializes the posting lists summaries-only, emittingdocs_/offsets_as count-0 arrays. Since the align helpers round-trip empty arrays byte-for-byte, the reader is unchanged and plainSeismicIndexoutput stays byte-identical.python_tests/test_disk_seismic_index.py(mmap-only contract, top-k′ block budget monotone/saturating, bit-exact fresh-build vs mmap-reload, id-map, filtering, empty/unbuilt, padding). No binding changes needed —disk_seismicis already reachable through SWIG.Issues Resolved
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.