Support building the unquantized indexes from an mmapped CSR - #42
Merged
zirui-song-18 merged 2 commits intoSep 2, 2026
Merged
Conversation
Signed-off-by: Zirui Song <zrsong@amazon.com>
zirui-song-18
requested review from
chishui,
model-collapse and
yuye-aws
as code owners
September 2, 2026 09:34
chishui
reviewed
Sep 2, 2026
Signed-off-by: Zirui Song <zrsong@amazon.com>
chishui
approved these changes
Sep 2, 2026
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
read_csr(kMmap)borrowsvectors_without going throughadd(), so DiskSeismic'snum_vectors_(read bywrite_indexand search) is synced after the base read. Add bit-exact convert ->read_csr(kMmap)-> build -> mmap-reload -> search tests for SeismicIndex and DiskSeismicIndex.Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.