Handle unrecognized SearchQueryRecord attributes during stream deserialization#573
Open
dzane17 wants to merge 1 commit into
Open
Conversation
dzane17
force-pushed
the
fix/resilient-attribute-deserialization
branch
from
6b7bd52 to
4742852
Compare
dzane17
requested review from
KishoreKicha14,
ansjcy,
deshsidd and
jainankitk
as code owners
Contributor
|
As long as we don't add any more custom attributes in the future, it looks good to me. |
…alization Signed-off-by: David Zane <davizane@amazon.com>
dzane17
force-pushed
the
fix/resilient-attribute-deserialization
branch
from
4742852 to
823173d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
During rolling upgrades, newer nodes may send
SearchQueryRecordattributes that older nodes don't recognize (e.g.SOURCE_TRUNCATED,FAILED). CurrentlyAttribute.readFromStreamcallsAttribute.valueOf()which throwsIllegalArgumentExceptionon unknown values, causing the entire node response to fail.This change makes deserialization forward-compatible by:
IllegalArgumentExceptioninreadFromStreamand returningnullfor unrecognized attribute namesreadAttributeMapwhile still consuming their values from the stream to maintain correct stream positionUnknown attributes are written via
writeGenericValue, soreadGenericValuecorrectly advances the stream past them. Attributes with custom serialization (SOURCE,TASK_RESOURCE_USAGES) already exist in all versions and will never be unknown.Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.