chore: replace interface{} with any and enforce use-any lint rule#189
Merged
Conversation
Enable the revive use-any rule in .golangci.yml and replace all
interface{} occurrences with any across the codebase.
Also derive GOTOOLCHAIN and ENVTEST_K8S_VERSION from go.mod at runtime
in the Makefile, and add GOTOOLCHAIN to the lint target to work around
a golangci-lint panic caused by k8s.io v0.36 dependencies declaring go 1.26.
Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
Collaborator
Author
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tiraboschi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tiraboschi
merged commit 2fe247a
into
openshift-virtualization:main
6 of 7 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable the revive use-any rule in .golangci.yml and replace all interface{} occurrences with any across the codebase.
Also derive GOTOOLCHAIN and ENVTEST_K8S_VERSION from go.mod at runtime in the Makefile, and add GOTOOLCHAIN to the lint target to work around a golangci-lint panic caused by k8s.io v0.36 dependencies declaring go 1.26.