Skip to content

STOR-2759: Rebase to v10.32.0 for OCP 4.22#26

Open
RomanBednar wants to merge 52 commits intoopenshift:mainfrom
RomanBednar:rebase-v10.32.0
Open

STOR-2759: Rebase to v10.32.0 for OCP 4.22#26
RomanBednar wants to merge 52 commits intoopenshift:mainfrom
RomanBednar:rebase-v10.32.0

Conversation

@RomanBednar
Copy link

Upstream changelogs:

Summary of changes

New Features

  • AMLFS style POSIX metadata support (#3317)
  • --include-root flag to preserve root properties with --preserve-XXXX flags (#3163)
  • Azure Files NFS-SMB transfers: --from-to=FileNFSFileSMB and --from-to=FileSMBFileNFS
  • Symlink support for Azure Files NFS: preserve (--preserve-symlinks=true), skip, or follow (--follow-symlinks=true)
  • Version checking now opt-in via --check-version flag (#3173)

Diff to upstream v10.32.0:

Azure/azure-storage-azcopy@v10.32.0...RomanBednar:rebase-v10.32.0

Previous rebase: #23

@openshift/storage

wonwuakpa-msft and others added 30 commits September 18, 2025 09:28
* only allow explicit version checking

* remove VC from e2e tests

* added test for check-version flag

* remove file

* e2e + unit test

* removed unit test, ensure backward compat

* line endings diff
* Correct incorrect folder tracker behavior

* Invert test for thoroughness

* Fix tests
* Implement request priority policy

* remove unused

* comments/lint
* redact

* more tests

---------

Co-authored-by: Gauri Lamunion <51212198+gapra-msft@users.noreply.github.com>
…ure#3191)

* add retry to the pscred

* proper fallback err handling

* fix lint

* fix lint

* added warning

* pr comments
* Fix symlink direct targets

* lint

* Undo accidental test edit

* Helper Methods

* Error out on lone symlink, expand testing
…#3239)

* Added properly error message for system to system container copy

* Added properly error message for system to system container copy

* Added properly error message for system to system container copy

* Added properly error message for system to system container copy

* Update common/util.go

Co-authored-by: Gauri Lamunion <51212198+gapra-msft@users.noreply.github.com>

* Added E2E test for system container copy scenario

* added a check to see if the containername is encoded

* Added E2E test

* Added E2E test

* Added E2E test

* Added E2E test

* Added E2E test

* incorporated review comments

* Introduce flags for NFS over REST support (Azure#2968)

* Added flags description (Azure#2994)

* Added support for copy/sync from Local linux <-> Azure Files NFS and Azure Files NFS <-> Azure Files NFS (Azure#2987)

* Fixed golangci-lint error

* Add the --nfs flag check for download scenario (Azure#3022)

* resolved conflicts

* Add NFS tests to E2E framework (Azure#3036)

* Default handling for hardlink for Azure Files NFS (Azure#3033)

* Add default permissions preservation logic if --preserve-permissions is set to false (Azure#3047)

* Default handling for symlink,hardlink and special files for Azure Files NFS - Phase-1 (Azure#3046)

* fixed golint error

* fixed golint

* Update hardlink flag name and check the sudo permission for the process (Azure#3078)

* Update ChangeLog for 10.30.0~preview.1 release

* Update flag description and error message

* Update ChangeLog for 10.30.0~preview.1 release

* Update flag description and error message

* Update ChangeLog.md

Co-authored-by: Vikas Bhansali <64532198+vibhansa-msft@users.noreply.github.com>

* Throw error and fail the job if destination share is not present for SMB and NFS both (S2S Copy) (Azure#3099)

* Remove --nfs flag and add NFS combinations in --from-to flag (Azure#3102)

* fixed golangci-lint errora

* fixed golangci-lint errors

* updates help message for NFS support (Azure#3132)

* Add support for transfer data Azure Files NFS <-> Azure Files SMB (Azure#3087)

* Clean up places where we call location.FileSMB || location.FileNFS (Azure#3212)

* Add symlink and special file skipped count to job progress log (Azure#3218)

* Symlink support for Local to Azure Files NFS (Azure#3201)

* Symlink support for NFS <-> NFS, NFS -> Local and SMB<->NFS (Azure#3238)

* Introduce FileSMB for non File s2s or upload/download paths (Azure#3211)

* while downloading with --preserve-permissions=false dont set the defaults for uid/gid (Azure#3246)

---------

Co-authored-by: wonwuakpa-msft <wonwuakpa@microsoft.com>
Co-authored-by: Gauri Lamunion <51212198+gapra-msft@users.noreply.github.com>
Co-authored-by: Vikas Bhansali <64532198+vibhansa-msft@users.noreply.github.com>
* Catch EADDRNOTAVAILABLE

* Merge linux and darwin helpers

* Header
* remove decoding from special chars

* checkpoint

* removed flag, default to NO decoding for all rm commands

* remove object content validation

* fix type for validation

* remove dry run check
* Refactor platform retry policy

* Apply suggestion from @Copilot

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Gauri Lamunion <51212198+gapra-msft@users.noreply.github.com>
* Add initial index.html for redirecting to GitHub wiki

* Remove outdated website

* Apply suggestion from @Copilot

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: wonwuakpa-msft <wonwuakpa@microsoft.com>
Co-authored-by: Gauri Lamunion <51212198+gapra-msft@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
… MSI (Azure#3257)

* resolve SFI item

* resolve SFI item

* resolve SFI item

* workload identity login added

* workload identity login added

* workload identity login added

* workload identity login added

* container cleanup

* container cleanup

* container cleanup

* incorporated comments

* Fixed test failure

---------

Co-authored-by: Gauri Lamunion <51212198+gapra-msft@users.noreply.github.com>
* root props init functionality

* add test

* WIP

* added creating stored object for blob root folders

* init

* init

* init

* testing

* tests

* changed return type

* clean ups

* cleanups

* removed preserve-root-props flag

* minor comments

* remove macOs perservePerm testing

* fix xAttr issue in ADO pipeline

---------

Co-authored-by: Gauri Lamunion <51212198+gapra-msft@users.noreply.github.com>
* initial traverser refactor

* Fix missed export

* Migrated UT

* Fix account traversers

* Move token manager to the client

* remove credential op options and credential info from ste that was unused

* Suggestions from copilot

* Copilot comment

* add copyright

* standardize error handling

* move lcm functionality to cmd folder

* Cpk may not be set for e2e tests

* using wrong cpk methods

* Fix tests and build

* fixed build for runner

* fix npe

* add ui hooks

* remove unused var

* try to fix flaky test
* root props init functionality

* add test

* WIP

* added creating stored object for blob root folders

* init

* init

* init

* testing

* tests

* changed return type

* clean ups

* cleanups

* removed preserve-root-props flag

* minor comments

* remove macOs perservePerm testing

* fix xAttr issue in ADO pipeline

* fix typos

* 2 retries to get access token

* 1s time diff

* dstObj creation

---------

Co-authored-by: Gauri Lamunion <51212198+gapra-msft@users.noreply.github.com>
* Migrated login, login status and logout to library

* Update azcopy/loginlogout.go

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Fixed seg fault for s3 and gcp transfers

* remove condition to call method

* Apply suggestion from @Copilot

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Apply suggestion from @Copilot

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* addressed comments

* refactor code to allow testability

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
gapra-msft and others added 22 commits November 24, 2025 12:51
* copy refactor

* Test list of versions fix

* Fixed TestDFSResource test

* Make logging happen in library

* Resolved some comments

* remove whitespace

* enable UT

* fix lint
* wip

* init commit

* explicit fail + test

* tests and warning added

* removed comment

* removed err catch for non-404, fixed test

* fixed the issue

* removed specific blob err handling

* removed handling silent errs in list traverser
* Updated dependencies and version for path release

* Update ChangeLog.md

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* hdi_isfolder shall always be set in lower case on backend

* Comment added

---------

Co-authored-by: Gauri Lamunion <51212198+gapra-msft@users.noreply.github.com>
* update 1ES pipeline

* make optional

* fix pipeline

* change for only release jobs

* need artifactName

* use consistent pool config

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* pull

* fix 1es pipeline issue

* remove sbom path from task

* change sbom drop path

* changed build drop path

* move manifest to signed dir

* add sbom param as unsigned to verifyartifacts stage

* release to gh

* 1es fix

* separate out OS build artifacts

* windows only

* windows fix

* add targetPath param to pipelineArtifact output

* removed dep

* another one

* make releasejob find previous artifact

* add builddroppath param to releasejob

* itemPatter, sbomPath, targetPath

* just windows

* add other stages

* windows job

* verify artifacts

* removed sbom

* change to buildartifact dir

* no downloadPath

* path seperator

* vmImage ubuntu

* added os specficiation

* migrate to managed identity auth

* wif auth, uncommented out other stages

* verify Sign & RemoveLinux steps

* revert bk to creds

* pmc installation from main

* use cert for test PMC installation

* use AZCLI task for testing pmc install instead

* final version, all stages in

* final version

* removed pipeline artifact output path

* added param validation

* param valid

* added comment and prevent release overwrites

* fix typo

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Gauri Lamunion <51212198+gapra-msft@users.noreply.github.com>
* Update dependencies

* Fix wrong version

* typo for benchmark command
* added force logging to root

* added to lib copy

* add SFL to cobra copy

* public

* dont check for dests

* enabled log setting in cmds

* deleted

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* removed setting dupe

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* init() is enough

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Gauri Lamunion <51212198+gapra-msft@users.noreply.github.com>
Azure#3213)

* Update README.md to clarify supported directions and authorization methods for `copy` and `sync` commands based on the current autogenerated ones in the wiki.

* Update README.md

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update README.md

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update README.md

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Refactor command authorization table in README.md for clarity and consistency

* Refactor command authorization tables in README.md for clarity and consistency

---------

Co-authored-by: Gauri Lamunion <51212198+gapra-msft@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* flag implementation & tests

* test backwards compat

* implement in sync, used bit masking

* add missing param to SMB validation

* fix remove test failures

* add check for mt posixStyle flag

* amlfs test

* Update common/unixStatAdapter.go

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* support poxisStyle in test framework

* add amlfs to stat, fix wrong type in test

* add assert

* fixed test

* fixed test

* fix typo

---------

Co-authored-by: Gauri Lamunion <51212198+gapra-msft@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Finalize folder tracker changes

* Add specialized erroring to files and blobfs creators

* fix lint

* Apply suggestions from code review

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Fix UT

* use is remote as condition

* deal with folder creation tracker error

* add success state to if statement

* removed duplicate comment

* do not create folders on canceled tx

* do not validate debugCheckState on failed tx

* edge case handling in state mismatches

* Revert fromTo.to condition

---------

Co-authored-by: Gauri Lamunion <gapra@microsoft.com>
Co-authored-by: Gauri Lamunion <51212198+gapra-msft@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: wonwuakpa-msft <wonwuakpa@microsoft.com>
* Changelog and version bump

* Update ChangeLog.md

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Fixed a regressed with wildcard upload downloads and list of files

* Upgraded version and Changelog

* Added extra breaking changes line
* fix md5 + test

* remove comment

* reword comment

* update version

* added -check-md5 test

* remove md5 test validationn for local

* completely remove md5 test validation

* update version for release
Additional changes:
- remove .github directory
- modify .gitignore to ignore executable files
- add .snyk file
- add Dockerfile, OWNERS, and OWNERS_ALIASES
- add vendor directory (go mod tidy && go mod vendor)
- update .ci-operator.yaml for ART 4.22 consistency
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 16, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 16, 2026

@RomanBednar: This pull request references STOR-2759 which is a valid jira issue.

Details

In response to this:

Upstream changelogs:

Summary of changes

New Features

  • AMLFS style POSIX metadata support (#3317)
  • --include-root flag to preserve root properties with --preserve-XXXX flags (#3163)
  • Azure Files NFS-SMB transfers: --from-to=FileNFSFileSMB and --from-to=FileSMBFileNFS
  • Symlink support for Azure Files NFS: preserve (--preserve-symlinks=true), skip, or follow (--follow-symlinks=true)
  • Version checking now opt-in via --check-version flag (#3173)

Diff to upstream v10.32.0:

Azure/azure-storage-azcopy@v10.32.0...RomanBednar:rebase-v10.32.0

Previous rebase: #23

@openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from gnufied and jsafrane February 16, 2026 14:20
@openshift-ci
Copy link

openshift-ci bot commented Feb 16, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RomanBednar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 16, 2026
@openshift-ci
Copy link

openshift-ci bot commented Feb 16, 2026

@RomanBednar: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants