Skip to content

Fix operator suggested namespace to match deployment namespace - #140

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
alebedev87:suggested-namespace
Sep 18, 2026
Merged

openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
alebedev87:suggested-namespace

Conversation

@alebedev87

Copy link
Copy Markdown
Contributor

Summary

The bundle's ClusterServiceVersion was suggesting installation in the bgp-cloud-connector namespace, but the operator is configured to deploy in openshift-bgp-cloud-connector via the kustomization base. This mismatch could cause users to install the operator in the wrong namespace, leading to integration issues with cloud credential operator and other namespace-aware components.

🤖 Generated with Claude Code

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@coderabbitai

coderabbitai Bot commented Sep 17, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: a0995c01-c32e-435c-8e87-9393fb3b8b43

📥 Commits

Reviewing files that changed from the base of the PR and between 4e67e4b and b4f5be5.

📒 Files selected for processing (2)
  • bundle/manifests/bgp-cloud-connector.clusterserviceversion.yaml
  • config/manifests/bases/bgp-cloud-connector.clusterserviceversion.yaml

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


📝 Walkthrough

Walkthrough

Updated the suggested namespace from bgp-cloud-connector to openshift-bgp-cloud-connector in both CSV manifests.

Suggested reviewers: jpinsonneau

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to b4f5b

The operator bundle now suggests the configured deployment namespace consistently, with no identified merge-blocking risk.

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description check ✅ Passed The description accurately explains the namespace mismatch and the namespace change in both CSV files.
Title check ✅ Passed The title clearly and concisely describes the primary change: aligning the operator suggested namespace with the deployment namespace.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The pull request changes only two CSV YAML metadata fields. It changes the suggested namespace from bgp-cloud-connector to the fixed string openshift-bgp-cloud-connector. No Ginkgo test titles or …
Test Structure And Quality ✅ Passed PASS: The reviewed range changes only two CSV YAML manifest files. Both changes update operatorframework.io/suggested-namespace from bgp-cloud-connector to openshift-bgp-cloud-connector. No Gink…
Microshift Test Compatibility ✅ Passed The pull request changes only two CSV manifest fields. Both changes update operatorframework.io/suggested-namespace from bgp-cloud-connector to openshift-bgp-cloud-connector. No Ginkgo e2e tests…
Single Node Openshift (Sno) Test Compatibility ✅ Passed The pull request changes only two CSV YAML files. Both changes update operatorframework.io/suggested-namespace; no Ginkgo e2e tests or other test files were added. The SNO compatibility check is the…
Topology-Aware Scheduling Compatibility ✅ Passed PASS — The pull request changes only two ClusterServiceVersion metadata fields: operatorframework.io/suggested-namespace changes from bgp-cloud-connector to openshift-bgp-cloud-connector. The au…
Ote Binary Stdout Contract ✅ Passed PASS: The pull request changes only two YAML manifest metadata values for operatorframework.io/suggested-namespace. It changes no Go files or process-level code. The diff contains no stdout writes, …
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PASS. The pull request changes only the suggested namespace metadata in two CSV files. It adds no Ginkgo tests and introduces no IPv4 or external-connectivity test behavior. The existing IPv4 strings …
No-Weak-Crypto ✅ Passed The pull request changes only the suggested namespace value in two CSV manifests. The authoritative diff contains two one-line replacements from bgp-cloud-connector to `openshift-bgp-cloud-connector…
Container-Privileges ✅ Passed The pull request changes only operatorframework.io/suggested-namespace in two CSV files. It does not introduce privileged: true, hostPID, hostNetwork, hostIPC, SYS_ADMIN, or `allowPrivileg…
No-Sensitive-Data-In-Logs ✅ Passed PASS: The pull request changes only two CSV metadata values for operatorframework.io/suggested-namespace. The diff adds no logging code and no passwords, tokens, API keys, PII, session IDs, hostname…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alebedev87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 17, 2026
@frobware

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 17, 2026
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2026
The bundle's ClusterServiceVersion suggested-namespace was `bgp-cloud-connector`,
but the operator is configured to deploy in `openshift-bgp-cloud-connector`.
Update the suggested namespace in both the source manifest and generated bundle.
@openshift-ci openshift-ci Bot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 17, 2026
@alebedev87

Copy link
Copy Markdown
Contributor Author

/retest

@red-hat-konflux-kflux-prd-rh02

Copy link
Copy Markdown
Contributor

All PipelineRuns for this commit have already succeeded. Use /retest <pipeline-name> to re-run a specific pipeline or /test to re-run all pipelines.

@openshift-ci

openshift-ci Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

@alebedev87: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@frobware

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2026
@openshift-merge-bot
openshift-merge-bot Bot merged commit 32b0e15 into openshift:main Sep 18, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants