Skip to content

OCPBUGS-83973: Upgrade grpc for CVE-2026-33186#105

Merged
openshift-merge-bot[bot] merged 2 commits into
openshift:release-4.22from
nrb:OCPBUGS-83973
May 19, 2026
Merged

OCPBUGS-83973: Upgrade grpc for CVE-2026-33186#105
openshift-merge-bot[bot] merged 2 commits into
openshift:release-4.22from
nrb:OCPBUGS-83973

Conversation

@nrb
Copy link
Copy Markdown

@nrb nrb commented May 5, 2026

Summary by CodeRabbit

  • Chores
    • Dependency version updates to maintain stability and compatibility.

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 5, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@nrb: This pull request references Jira Issue OCPBUGS-83973, which is invalid:

  • expected the vulnerability to target either version "5.0." or "openshift-5.0.", but it targets "4.22.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 5, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: a9b81051-0e73-4326-961b-cc5956e63993

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Walkthrough

A single indirect dependency version bump for google.golang.org/grpc from v1.79.1 to v1.79.3 in the Go module file.

Changes

Dependency Update

Layer / File(s) Summary
Module Dependency
go.mod
Indirect dependency google.golang.org/grpc is bumped from v1.79.1 to v1.79.3.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: upgrading gRPC to address a CVE vulnerability, with reference to the issue tracker number.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The custom check for stable/deterministic Ginkgo test names is not applicable to this PR. The PR modifies test files but all tests use standard Go testing (testing.T) framework, not Ginkgo.
Test Structure And Quality ✅ Passed This PR updates go.mod for a gRPC CVE fix. The codebase uses standard Go testing, not Ginkgo. The custom check for "Ginkgo test code" is not applicable to this repository.
Microshift Test Compatibility ✅ Passed PR only updates grpc dependency in go.mod. No new Ginkgo e2e tests added. Repository uses standard Go testing, not Ginkgo. Check not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR only updates grpc dependency in go.mod. No new Ginkgo e2e tests added. Repository is a Kubernetes Cloud Provider using standard Go testing, not Ginkgo. Check not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed PR only updates grpc dependency. No deployment manifests or operator code modified. Check applies only to such changes.
Ote Binary Stdout Contract ✅ Passed Dependency upgrade only, no code changes. Not an OTE binary; check not applicable.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed No new Ginkgo e2e tests added. PR only updates go.mod dependency versions for CVE-2026-33186. Custom check only applies when new Ginkgo tests are introduced.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from racheljpg and theobarberbany May 5, 2026 16:41
@nrb
Copy link
Copy Markdown
Author

nrb commented May 5, 2026

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 5, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@nrb: This pull request references Jira Issue OCPBUGS-83973, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.0.0) matches configured target version for branch (5.0.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@damdo
Copy link
Copy Markdown
Member

damdo commented May 13, 2026

@nrb can you please fix the commits here?

@nrb nrb force-pushed the OCPBUGS-83973 branch from 30b63e1 to 7364e3b Compare May 13, 2026 18:51
@nrb nrb changed the base branch from main to release-4.22 May 13, 2026 18:52
@openshift-ci-robot openshift-ci-robot removed the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label May 13, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@nrb: This pull request references Jira Issue OCPBUGS-83973, which is invalid:

  • expected the vulnerability to target either version "4.22." or "openshift-4.22.", but it targets "5.0" instead
  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-83587 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Summary by CodeRabbit

  • Chores
  • Dependency version updates to maintain stability and compatibility.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label May 13, 2026
nrb added 2 commits May 13, 2026 14:54
Signed-off-by: Nolan Brubaker <nolan@nbrubaker.com>
Signed-off-by: Nolan Brubaker <nolan@nbrubaker.com>
@nrb nrb force-pushed the OCPBUGS-83973 branch from 7364e3b to 52af08d Compare May 13, 2026 18:54
@damdo
Copy link
Copy Markdown
Member

damdo commented May 19, 2026

/test regression-clusterinfra-ibmcloud-ipi-ccm

@damdo
Copy link
Copy Markdown
Member

damdo commented May 19, 2026

/test ?

@damdo
Copy link
Copy Markdown
Member

damdo commented May 19, 2026

/test e2e-ibmcloud

2 similar comments
@damdo
Copy link
Copy Markdown
Member

damdo commented May 19, 2026

/test e2e-ibmcloud

@damdo
Copy link
Copy Markdown
Member

damdo commented May 19, 2026

/test e2e-ibmcloud

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 19, 2026

@nrb: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ibmcloud 52af08d link false /test e2e-ibmcloud
ci/prow/regression-clusterinfra-ibmcloud-ipi-ccm 52af08d link false /test regression-clusterinfra-ibmcloud-ipi-ccm

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@nrb
Copy link
Copy Markdown
Author

nrb commented May 19, 2026

/jira refresh

/verified bypass

The e2e-ibmcloud forkflow is perma-failing, see: https://redhat-internal.slack.com/archives/C68TNFWA2/p1779192959794109

@openshift-ci-robot
Copy link
Copy Markdown

@nrb: This pull request references Jira Issue OCPBUGS-83973, which is invalid:

  • expected the vulnerability to target either version "4.22." or "openshift-4.22.", but it targets "5.0" instead
  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

/verified bypass

The e2e-ibmcloud forkflow is perma-failing, see: https://redhat-internal.slack.com/archives/C68TNFWA2/p1779192959794109

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label May 19, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@nrb: The verified label has been added.

Details

In response to this:

/jira refresh

/verified bypass

The e2e-ibmcloud forkflow is perma-failing, see: https://redhat-internal.slack.com/archives/C68TNFWA2/p1779192959794109

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@nrb
Copy link
Copy Markdown
Author

nrb commented May 19, 2026

/jira refresh

@openshift-ci-robot
Copy link
Copy Markdown

@nrb: This pull request references Jira Issue OCPBUGS-83973, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@nrb
Copy link
Copy Markdown
Author

nrb commented May 19, 2026

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 19, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@nrb: This pull request references Jira Issue OCPBUGS-83973, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-83587 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-83587 targets the "5.0.0" version, which is one of the valid target versions: 5.0.0
  • bug has dependents
Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Copy Markdown
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@damdo
Copy link
Copy Markdown
Member

damdo commented May 19, 2026

/label backport-risk-assessed

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 19, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 19, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. labels May 19, 2026
@openshift-merge-bot openshift-merge-bot Bot merged commit 24cff9a into openshift:release-4.22 May 19, 2026
9 of 11 checks passed
@openshift-ci-robot
Copy link
Copy Markdown

@nrb: Jira Issue Verification Checks: Jira Issue OCPBUGS-83973
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-83973 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

Summary by CodeRabbit

  • Chores
  • Dependency version updates to maintain stability and compatibility.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants