Skip to content

[release-4.17] OCPBUGS-80063: Bump google.golang.org/grpc to v1.79.3 #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ocp-sustaining-admins wants to merge 2 commits into
base: release-4.17
Choose a base branch
from
Open

[release-4.17] OCPBUGS-80063: Bump google.golang.org/grpc to v1.79.3 #201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
749e8e2
OCPBUGS-80063: Bump google.golang.org/grpc to v1.79.3
rh-arc[bot] May 4, 2026
a0e132a
fix lint timeout issue
MrSanketkumar May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
4 changes: 2 additions & 2 deletions .golangci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
run:
# Default timeout is 1m, up to give more room
timeout: 4m
# Default timeout is 1m, increased for slower CI environments
timeout: 10m

linters:
enable:
Expand Down
44 changes: 23 additions & 21 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
module github.com/openshift/cluster-olm-operator

go 1.22
go 1.22.0

toolchain go1.22.1
toolchain go1.22.12

require (
github.com/openshift/api v0.0.0-20240424142232-29a704bf5aa2
Expand All @@ -11,7 +11,7 @@ require (
github.com/openshift/library-go v0.0.0-20240426153406-52527b886e57
github.com/spf13/cobra v1.7.0
github.com/spf13/pflag v1.0.5
golang.org/x/text v0.14.0
golang.org/x/text v0.21.0
k8s.io/api v0.29.0
k8s.io/apiextensions-apiserver v0.29.0
k8s.io/apimachinery v0.29.0
Expand All @@ -29,15 +29,15 @@ require (
github.com/beorn7/perks v1.0.1 // indirect
github.com/blang/semver/v4 v4.0.0 // indirect
github.com/cenkalti/backoff/v4 v4.2.1 // indirect
github.com/cespare/xxhash/v2 v2.2.0 // indirect
github.com/cespare/xxhash/v2 v2.3.0 // indirect
github.com/coreos/go-semver v0.3.1 // indirect
github.com/coreos/go-systemd/v22 v22.5.0 // indirect
github.com/davecgh/go-spew v1.1.1 // indirect
github.com/emicklei/go-restful/v3 v3.11.0 // indirect
github.com/evanphx/json-patch v4.12.0+incompatible // indirect
github.com/felixge/httpsnoop v1.0.3 // indirect
github.com/fsnotify/fsnotify v1.7.0 // indirect
github.com/go-logr/logr v1.3.0 // indirect
github.com/go-logr/logr v1.4.2 // indirect
github.com/go-logr/stdr v1.2.2 // indirect
github.com/go-openapi/jsonpointer v0.19.6 // indirect
github.com/go-openapi/jsonreference v0.20.2 // indirect
Expand All @@ -49,7 +49,7 @@ require (
github.com/google/gnostic-models v0.6.8 // indirect
github.com/google/go-cmp v0.6.0 // indirect
github.com/google/gofuzz v1.2.0 // indirect
github.com/google/uuid v1.3.1 // indirect
github.com/google/uuid v1.6.0 // indirect
github.com/grpc-ecosystem/go-grpc-prometheus v1.2.0 // indirect
github.com/grpc-ecosystem/grpc-gateway/v2 v2.16.0 // indirect
github.com/imdario/mergo v0.3.7 // indirect
Expand All @@ -73,32 +73,32 @@ require (
go.etcd.io/etcd/api/v3 v3.5.10 // indirect
go.etcd.io/etcd/client/pkg/v3 v3.5.10 // indirect
go.etcd.io/etcd/client/v3 v3.5.10 // indirect
go.opentelemetry.io/auto/sdk v1.1.0 // indirect
go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.44.0 // indirect
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot May 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | 🏗️ Heavy lift

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Description: Check for security advisories and newer versions of flagged dependencies

echo "=== Checking for OpenTelemetry otelgrpc updates ==="
gh api graphql -f query='
{
  securityVulnerabilities(first: 5, ecosystem: GO, package: "go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc") {
    nodes {
      advisory {
        summary
        severity
        publishedAt
      }
      vulnerableVersionRange
      firstPatchedVersion {
        identifier
      }
    }
  }
}'

echo -e "\n=== Checking for OpenTelemetry SDK updates ==="
gh api graphql -f query='
{
  securityVulnerabilities(first: 5, ecosystem: GO, package: "go.opentelemetry.io/otel/sdk") {
    nodes {
      advisory {
        summary
        severity
      }
      vulnerableVersionRange
      firstPatchedVersion {
        identifier
      }
    }
  }
}'

echo -e "\n=== Checking for golang.org/x/crypto updates ==="
gh api graphql -f query='
{
  securityVulnerabilities(first: 5, ecosystem: GO, package: "golang.org/x/crypto") {
    nodes {
      advisory {
        summary
        severity
      }
      vulnerableVersionRange
      firstPatchedVersion {
        identifier
      }
    }
  }
}'

echo -e "\n=== Checking for golang.org/x/oauth2 updates ==="
gh api graphql -f query='
{
  securityVulnerabilities(first: 5, ecosystem: GO, package: "golang.org/x/oauth2") {
    nodes {
      advisory {
        summary
        severity
      }
      vulnerableVersionRange
      firstPatchedVersion {
        identifier
      }
    }
  }
}'

Repository: openshift/cluster-olm-operator

Length of output: 2517

🏁 Script executed:

head -95 go.mod | tail -25

Repository: openshift/cluster-olm-operator

Length of output: 1370

Update multiple HIGH severity vulnerabilities in dependencies.

OSV Scanner has identified 5 HIGH severity vulnerabilities in the current dependency versions:

  1. Line 77 - go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.44.0:

    • DoS vulnerability due to unbound cardinality metrics (patched in v0.46.0)

  2. Line 83 - go.opentelemetry.io/otel/sdk v1.34.0:

    • Arbitrary Code Execution via PATH hijacking (patched in v1.40.0 or v1.43.0)

  3. Line 89 - golang.org/x/crypto v0.32.0:

    • DoS via slow or incomplete key exchange (patched in v0.35.0)

  4. Line 92 - golang.org/x/oauth2 v0.25.0:

    • Improper validation vulnerability (patched in v0.27.0)

All flagged versions are within vulnerable ranges. Consider updating these dependencies to their respective patched versions, either in this PR or as a follow-up security update.

🧰 Tools
🪛 OSV Scanner (2.3.8)

[HIGH] 77-77: go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc 0.44.0: Denial of service in go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc

(GO-2023-2331)

[HIGH] 77-77: go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc 0.44.0: otelgrpc DoS vulnerability due to unbound cardinality metrics

(GHSA-8pgv-569h-w5rw)

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@go.mod` at line 77, Update the vulnerable dependency versions in go.mod: bump
go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc to
v0.46.0, go.opentelemetry.io/otel/sdk to a patched release (e.g., v1.43.0),
golang.org/x/crypto to v0.35.0, and golang.org/x/oauth2 to v0.27.0; then run `go
get`/`go get module@version` (or edit go.mod and run `go mod tidy`) to refresh
go.sum, rebuild and run tests, and re-run the OSV/security scanner to confirm
the vulnerabilities for these modules (otelgrpc, go.opentelemetry.io/otel/sdk,
golang.org/x/crypto, golang.org/x/oauth2) are resolved.

go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.44.0 // indirect
go.opentelemetry.io/otel v1.20.0 // indirect
go.opentelemetry.io/otel v1.34.0 // indirect
go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.20.0 // indirect
go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.20.0 // indirect
go.opentelemetry.io/otel/metric v1.20.0 // indirect
go.opentelemetry.io/otel/sdk v1.20.0 // indirect
go.opentelemetry.io/otel/trace v1.20.0 // indirect
go.opentelemetry.io/otel/metric v1.34.0 // indirect
go.opentelemetry.io/otel/sdk v1.34.0 // indirect
go.opentelemetry.io/otel/trace v1.34.0 // indirect
go.opentelemetry.io/proto/otlp v1.0.0 // indirect
go.uber.org/atomic v1.10.0 // indirect
go.uber.org/multierr v1.11.0 // indirect
go.uber.org/zap v1.24.0 // indirect
golang.org/x/crypto v0.16.0 // indirect
golang.org/x/crypto v0.32.0 // indirect
golang.org/x/exp v0.0.0-20220722155223-a9213eeb770e // indirect
golang.org/x/net v0.19.0 // indirect
golang.org/x/oauth2 v0.11.0 // indirect
golang.org/x/sync v0.3.0 // indirect
golang.org/x/sys v0.15.0 // indirect
golang.org/x/term v0.15.0 // indirect
golang.org/x/net v0.34.0 // indirect
golang.org/x/oauth2 v0.25.0 // indirect
golang.org/x/sync v0.10.0 // indirect
golang.org/x/sys v0.29.0 // indirect
golang.org/x/term v0.28.0 // indirect
golang.org/x/time v0.3.0 // indirect
google.golang.org/appengine v1.6.7 // indirect
google.golang.org/genproto v0.0.0-20230822172742-b8732ec3820d // indirect
google.golang.org/genproto/googleapis/api v0.0.0-20230822172742-b8732ec3820d // indirect
google.golang.org/genproto/googleapis/rpc v0.0.0-20230822172742-b8732ec3820d // indirect
google.golang.org/grpc v1.59.0 // indirect
google.golang.org/protobuf v1.33.0 // indirect
google.golang.org/genproto/googleapis/api v0.0.0-20250106144421-5f5ef82da422 // indirect
google.golang.org/genproto/googleapis/rpc v0.0.0-20250115164207-1a7da9e5054f // indirect
google.golang.org/grpc v1.67.1 // indirect
google.golang.org/protobuf v1.36.4 // indirect
gopkg.in/inf.v0 v0.9.1 // indirect
gopkg.in/natefinch/lumberjack.v2 v2.2.1 // indirect
gopkg.in/yaml.v2 v2.4.0 // indirect
Expand All @@ -113,3 +113,5 @@ require (
sigs.k8s.io/structured-merge-diff/v4 v4.4.1 // indirect
sigs.k8s.io/yaml v1.3.0 // indirect
)

replace google.golang.org/grpc => github.com/openshift-sustaining/grpc-go v1.71.3-sec.1
Copy link
Copy Markdown
Contributor

@tmshort tmshort May 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is v1.71.3, whereas the fix is looking for v1.79.3; does this contain the proper fix?

Copy link
Copy Markdown

@MrSanketkumar MrSanketkumar May 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this version includes the gRPC CVE fix (v1.79.3). We have created patched versions based on the Go version used by each component, so the fix is already included and compatible.

Loading