Conversation
|
Hi @codekow. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
simonpasquier
left a comment
There was a problem hiding this comment.
can you elaborate on the advantages of switching from markdownlint to PyMarkdown? IIRC we picked up the former because it is also used by https://github.com/openshift/enhancements.
|
@simonpasquier Thanks for the feedback, I'll split these efforts into multiple PRs |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: codekow The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
I have changed this PR to only address the spelling mistakes. I will do a separate PR for both spelling and markdown linting tools. |
|
I'd expect that we have a script + dictionary to check spelling in that PR. Then we can extend the |
I'm not sure how the CI is setup for this, but I have provided another PR to show how to run those tools (modifications can be made to match preferred path). #407 |
|
The CI configuration is https://github.com/openshift/release/blob/main/ci-operator/config/openshift/runbooks/openshift-runbooks-master.yaml I expect that the script + dictionary are incorporated in this PR. |
Uh oh!
There was an error while loading. Please reload this page.