Skip to content

fix: spelling errors#405

Open
codekow wants to merge 1 commit intoopenshift:masterfrom
codekow:update-lint
Open

fix: spelling errors#405
codekow wants to merge 1 commit intoopenshift:masterfrom
codekow:update-lint

Conversation

@codekow
Copy link

@codekow codekow commented Feb 12, 2026

  • Correct spelling errors in documentation.
  • Include symlinks to misspelled docs until fixed upstream

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 12, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 12, 2026

Hi @codekow. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codekow codekow marked this pull request as ready for review February 12, 2026 04:41
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 12, 2026
@openshift-ci openshift-ci bot requested review from Clee2691 and bburt-rh February 12, 2026 04:42
Copy link
Contributor

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you elaborate on the advantages of switching from markdownlint to PyMarkdown? IIRC we picked up the former because it is also used by https://github.com/openshift/enhancements.

@codekow
Copy link
Author

codekow commented Feb 16, 2026

@simonpasquier Thanks for the feedback, I'll split these efforts into multiple PRs

@codekow codekow marked this pull request as draft February 16, 2026 18:03
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 16, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 16, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: codekow
Once this PR has been reviewed and has the lgtm label, please assign apinnick, bmeng, cahartma, cgwalters, elbehery, malayparida2000, marioferh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codekow codekow marked this pull request as ready for review February 16, 2026 23:59
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 16, 2026
@codekow codekow changed the title update: linting fix: spelling errors Feb 16, 2026
@codekow
Copy link
Author

codekow commented Feb 17, 2026

I have changed this PR to only address the spelling mistakes.

I will do a separate PR for both spelling and markdown linting tools.

@simonpasquier
Copy link
Contributor

I'd expect that we have a script + dictionary to check spelling in that PR. Then we can extend the markdownlint job config to actually run the check.

@codekow
Copy link
Author

codekow commented Feb 17, 2026

I'd expect that we have a script + dictionary to check spelling in that PR. Then we can extend the markdownlint job config to actually run the check.

I'm not sure how the CI is setup for this, but I have provided another PR to show how to run those tools (modifications can be made to match preferred path). #407

@simonpasquier
Copy link
Contributor

The CI configuration is https://github.com/openshift/release/blob/main/ci-operator/config/openshift/runbooks/openshift-runbooks-master.yaml

I expect that the script + dictionary are incorporated in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants