Skip to content

Update rustBench Wave network model - #10

Merged
brettheap merged 1 commit into
mainfrom
fix/rust-wave-network-pointer
Jul 25, 2026
Merged

Update rustBench Wave network model#10
brettheap merged 1 commit into
mainfrom
fix/rust-wave-network-pointer

Conversation

@brettheap

@brettheap brettheap commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

Summary

Validation

  • cold scripts/wave-container-shell.sh --check rustBench passed
  • warm check reused the same container ID and start time
  • rustBench, pyBench, and flutterBench remain running on separate networks with zero restarts

Summary by Sourcery

Update the rustBench devBench to use the latest rustBench submodule and a distinct Wave network model for its Compose setup.

Enhancements:

  • Assign a unique logical Compose network key to rustBench while preserving the shared dev-benches group and MTU 1400 network configuration.

Chores:

Copilot AI review requested due to automatic review settings July 25, 2026 19:27
@brettheap

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

1 similar comment
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@brettheap
brettheap merged commit 2587d0d into main Jul 25, 2026
4 checks passed
@brettheap
brettheap deleted the fix/rust-wave-network-pointer branch July 25, 2026 19:28

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the rustBench workbench integration by bumping the devBenches/rustBench git submodule to opensoft/rustBench#2 and adjusting the Compose networking model so rustBench has its own logical network key while still retaining the shared dev-benches grouping and the MTU-1400 network behavior.

Changes:

  • Update the devBenches/rustBench submodule pointer to opensoft/rustBench#2.
  • Adjust rustBench Docker Compose networking to avoid network-key collisions while preserving the shared group and MTU 1400 isolation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sourcery-ai

sourcery-ai Bot commented Jul 25, 2026

Copy link
Copy Markdown

🧙 Sourcery has finished reviewing your pull request!


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants