Fix durable rustBench Tauri startup from Wave - #12
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
🧙 Sourcery has finished reviewing your pull request! Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
Author
|
@codex review |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
Improves Wave-driven workBench container startup durability for rust-bench, particularly under WSL/WSLg, by making mount selection more environment-aware and ensuring user cache directories don’t end up root-owned.
Changes:
- Pre-create user-owned cache roots (
~/.vscode-server/extensionsand~/.cargo) in the user-layer image so freshly-initialized named volumes inherit correct ownership. - Update
wave-container-shell.shto conditionally add the rustBench WSLg compose override only when/mnt/wslgis present, and to recreaterust-benchwhen required mounts are missing. - Add a startup step that repairs ownership of
~/.cargoinsiderust-bench.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
user-layer/Dockerfile |
Pre-creates user-owned cache directories so initialized volumes don’t become root-owned. |
scripts/wave-container-shell.sh |
Conditionally applies WSLg compose override, detects missing required mounts (incl. ~/.cargo), recreates containers when needed, and repairs Cargo cache ownership. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+327
to
+331
| ensure_user_cargo_cache() { | ||
| [[ "$container" == "rust-bench" ]] || return 0 | ||
| docker exec --user root "$container" sh -c \ | ||
| "mkdir -p '/home/${container_user}/.cargo' && chown -R '${container_user}:${container_user}' '/home/${container_user}/.cargo'" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
bash -n scripts/wave-container-shell.shdevBenches/scripts/test-helper-safety.shscripts/wave-container-shell.sh --check rustBenchpnpm installin profile-switcherpnpm tauri devreaches and runs the Tauri desktop binary under WSLgSummary by Sourcery
Improve rustBench container startup and durability, especially under Wave on WSL/WSLg.
Enhancements: