fix: encoding of IPv6 addresses in impl From<SocketAddr> for Socket#179
Merged
NobodyXu merged 1 commit intoopenssh-rust:masterfrom Dec 3, 2025
Merged
fix: encoding of IPv6 addresses in impl From<SocketAddr> for Socket#179NobodyXu merged 1 commit intoopenssh-rust:masterfrom
impl From<SocketAddr> for Socket#179NobodyXu merged 1 commit intoopenssh-rust:masterfrom
Conversation
Collaborator
|
Codecov Report❌ Patch coverage is
Additional details and impacted files
🚀 New features to boost your workflow:
|
NobodyXu
approved these changes
Dec 3, 2025
Member
NobodyXu
left a comment
There was a problem hiding this comment.
Thank you! Will cit a release now
Merged
Contributor
Author
|
That was quick! Thank you very much 😃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the
impl From<SocketAddr> for Socket<'static>implementation wrap IPv6 addresses in square brackets, so that an address like an address like2606:4700:4700::1111port123gets encoded as[2606:4700:4700::1111]:123instead of2606:4700:4700::1111:123as it does now.This is also what the std
Displayimplementation forSocketAddrdoes: https://doc.rust-lang.org/1.91.1/src/core/net/socket_addr.rs.html#678