WIP - Consume s2i content in kuttl tests by fmount · Pull Request #646 · openstack-k8s-operators/manila-operator

fmount · 2026-09-09T08:52:47Z

Update kuttl jobs to consume s2i content

coderabbitai · 2026-09-09T08:52:54Z

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (1)

WIP

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Advanced

Run ID: 62a9c918-1652-46b6-995b-7ed541767cac

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

_{Comment @coderabbitai help to get the list of available commands.}

openshift-ci · 2026-09-09T08:52:56Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fmount

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [fmount]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

fmount · 2026-09-09T10:04:16Z

Defaulted container "manila-share" out of: manila-share, probe
2026-09-09 09:58:46.243 1 DEBUG oslo_concurrency.lockutils [-] Acquiring lock "singleton_lock" lock /usr/lib/python3.9/site-packages/oslo_concurrency/lockutils.py:312
2026-09-09 09:58:46.243 1 DEBUG oslo_concurrency.lockutils [-] Acquired lock "singleton_lock" lock /usr/lib/python3.9/site-packages/oslo_concurrency/lockutils.py:315
2026-09-09 09:58:46.243 1 DEBUG oslo_concurrency.lockutils [-] Releasing lock "singleton_lock" lock /usr/lib/python3.9/site-packages/oslo_concurrency/lockutils.py:333
2026-09-09 09:58:46.311 1 INFO oslo_service.periodic_task [-] Skipping periodic task update_share_usage_size because it is disabled
2026-09-09 09:58:46.312 1 CRITICAL manila [None req-c43bfb75-82aa-4829-aca0-7fcc5e245074 - - - - - -] Unhandled error: ModuleNotFoundError: No module named 'manila.tests'
2026-09-09 09:58:46.312 1 ERROR manila Traceback (most recent call last):
2026-09-09 09:58:46.312 1 ERROR manila   File "/usr/bin/manila-share", line 10, in <module>
2026-09-09 09:58:46.312 1 ERROR manila     sys.exit(main())
2026-09-09 09:58:46.312 1 ERROR manila   File "/usr/lib/python3.9/site-packages/manila/cmd/share.py", line 55, in main
2026-09-09 09:58:46.312 1 ERROR manila     server = service.Service.create(host=host,
2026-09-09 09:58:46.312 1 ERROR manila   File "/usr/lib/python3.9/site-packages/manila/service.py", line 232, in create
2026-09-09 09:58:46.312 1 ERROR manila     service_obj = cls(host, binary, topic, manager,
2026-09-09 09:58:46.312 1 ERROR manila   File "/usr/lib/python3.9/site-packages/manila/service.py", line 124, in __init__
2026-09-09 09:58:46.312 1 ERROR manila     self.manager = manager_class(host=self.host,
2026-09-09 09:58:46.312 1 ERROR manila   File "/usr/lib/python3.9/site-packages/manila/share/manager.py", line 276, in __init__
2026-09-09 09:58:46.312 1 ERROR manila     self.driver = importutils.import_object(
2026-09-09 09:58:46.312 1 ERROR manila   File "/usr/lib/python3.9/site-packages/oslo_utils/importutils.py", line 44, in import_object
2026-09-09 09:58:46.312 1 ERROR manila     return import_class(import_str)(*args, **kwargs)
2026-09-09 09:58:46.312 1 ERROR manila   File "/usr/lib/python3.9/site-packages/oslo_utils/importutils.py", line 30, in import_class
2026-09-09 09:58:46.312 1 ERROR manila     __import__(mod_str)
2026-09-09 09:58:46.312 1 ERROR manila ModuleNotFoundError: No module named 'manila.tests'
2026-09-09 09:58:46.312 1 ERROR manila

we might require to include manila.tests in the container I suppose (cc @gouthampacha)

centosinfra-prod-github-app · 2026-09-09T12:40:21Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/871921a76f07465d8d219e15057e523e

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 03m 26s
⚠️ manila-operator-kuttl SKIPPED Skipped due to failed job manila-s2i-content-provider
❌ manila-s2i-content-provider NODE_FAILURE Node(set) request 100-0000197101 failed in 0s
✔️ manila-operator-tempest SUCCESS in 1h 36m 22s

fmount · 2026-09-09T13:05:52Z

recheck

centosinfra-prod-github-app · 2026-09-09T15:25:54Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/cf3c6cdde5a8497ab9993f0c11b45c91

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 18m 19s
❌ manila-operator-kuttl FAILURE in 39m 13s
✔️ manila-s2i-content-provider SUCCESS in 1h 17m 05s
✔️ manila-operator-tempest SUCCESS in 1h 40m 24s

gouthampacha · 2026-09-09T21:14:53Z

Hey @fmount

yeah, since the manila-share RPM doesn't contain the "manila.tests" module, the dummy driver isn't included. It'd have been perfect for this use-case. Maybe it still can be if we can shove it into the testing here, and use it via the extraMounts logic when we don't use the s2i container images?

You're right that with s2i, we kinda get this package because we're closer to manila's source there - and we include everything in the package, including tests today.

An LLM was tortured to get something along these lines as a brittle dev/CI-only flake we can incorporate:

curl -sO https://opendev.org/openstack/manila/raw/commit/849119d900f13a6ff5604943138c5d37d46aedb9/manila/tests/share/drivers/dummy.py
: > empty
oc create configmap manila-dummy-driver -n openstack \
  --from-file=dummy.py=dummy.py \
  --from-file=pkg_init=empty \
  --from-file=share_init=empty \
  --from-file=drivers_init=empty \
  --dry-run=client -o yaml > manila-dummy-driver-cm.yaml

then:

spec:
  manila:
    template:
      extraMounts:
        - name: manila-dummy-driver
          extraVol:
            - extraVolType: Undefined
              propagation: [ManilaShare]       
              volumes:
                - name: manila-dummy-driver
                  configMap:
                    name: manila-dummy-driver
                    items:  
                      - {key: pkg_init,     path: __init__.py}
                      - {key: share_init,   path: share/__init__.py}
                      - {key: drivers_init, path: share/drivers/__init__.py}
                      - {key: dummy.py,     path: share/drivers/dummy.py}
              mounts:
                - name: manila-dummy-driver
                  mountPath: /usr/lib/python3.9/site-packages/manila/tests
                  readOnly: true
      manilaShares:
        dummy:
          replicas: 1
          customServiceConfig: |
            [dummy]
            driver_handles_share_servers = False
            share_driver = manila.tests.share.drivers.dummy.DummyDriver
            share_backend_name = dummy

centosinfra-prod-github-app · 2026-09-09T23:03:11Z

Build succeeded (check pipeline).
https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/ee105473a7684f11938d90731e53d54a

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 57m 14s
✔️ manila-operator-kuttl SUCCESS in 43m 52s
✔️ manila-s2i-content-provider SUCCESS in 1h 04m 50s
✔️ manila-operator-tempest SUCCESS in 1h 36m 13s

fmount · 2026-09-10T08:31:29Z

Hey @fmount

yeah, since the manila-share RPM doesn't contain the "manila.tests" module, the dummy driver isn't included. It'd have been perfect for this use-case. Maybe it still can be if we can shove it into the testing here, and use it via the extraMounts logic when we don't use the s2i container images?

You're right that with s2i, we kinda get this package because we're closer to manila's source there - and we include everything in the package, including tests today.

An LLM was tortured to get something along these lines as a brittle dev/CI-only flake we can incorporate:

curl -sO https://opendev.org/openstack/manila/raw/commit/849119d900f13a6ff5604943138c5d37d46aedb9/manila/tests/share/drivers/dummy.py
: > empty
oc create configmap manila-dummy-driver -n openstack \
  --from-file=dummy.py=dummy.py \
  --from-file=pkg_init=empty \
  --from-file=share_init=empty \
  --from-file=drivers_init=empty \
  --dry-run=client -o yaml > manila-dummy-driver-cm.yaml

then:

spec:
  manila:
    template:
      extraMounts:
        - name: manila-dummy-driver
          extraVol:
            - extraVolType: Undefined
              propagation: [ManilaShare]       
              volumes:
                - name: manila-dummy-driver
                  configMap:
                    name: manila-dummy-driver
                    items:  
                      - {key: pkg_init,     path: __init__.py}
                      - {key: share_init,   path: share/__init__.py}
                      - {key: drivers_init, path: share/drivers/__init__.py}
                      - {key: dummy.py,     path: share/drivers/dummy.py}
              mounts:
                - name: manila-dummy-driver
                  mountPath: /usr/lib/python3.9/site-packages/manila/tests
                  readOnly: true
      manilaShares:
        dummy:
          replicas: 1
          customServiceConfig: |
            [dummy]
            driver_handles_share_servers = False
            share_driver = manila.tests.share.drivers.dummy.DummyDriver
            share_backend_name = dummy

Thanks @gouthampacha for checking it. I think that 18 jobs can continue to use ceph backend as the goal is to remove it from main, where we will actually rely on s2i generated content. I confirmed w/ the last run that manila.tests module is present and the DummyDriver can be used, so no need to hack it via extraMounts. Following up on #647 and keep using this patch to experiment.

centosinfra-prod-github-app · 2026-09-10T14:25:17Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/02fbda5566ea43bcb2491616fcdee090

✔️ openstack-k8s-operators-content-provider SUCCESS in 4h 22m 19s
❌ manila-operator-kuttl FAILURE in 42m 03s
✔️ manila-s2i-content-provider SUCCESS in 4h 12m 24s
✔️ manila-operator-tempest SUCCESS in 1h 32m 21s

centosinfra-prod-github-app · 2026-09-10T19:37:00Z

Build succeeded (check pipeline).
https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/3d75d01fcb174a66aced49ede5c87b8d

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 03m 39s
✔️ manila-operator-kuttl SUCCESS in 42m 45s
✔️ manila-s2i-content-provider SUCCESS in 3h 45m 45s
✔️ manila-operator-tempest SUCCESS in 1h 33m 01s

centosinfra-prod-github-app · 2026-09-10T21:55:24Z

Build succeeded (check pipeline).
https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/a777005e123c451ebaf49336edf4f411

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 03m 05s
✔️ manila-operator-kuttl SUCCESS in 42m 01s
✔️ manila-s2i-content-provider SUCCESS in 1h 23m 27s
✔️ manila-operator-tempest SUCCESS in 1h 32m 37s

fmount · 2026-09-11T09:33:07Z

      - tests?\/functional
      - ^renovate.json$
    vars:
+      cifmw_crc_additional_insecure_registries:


This part can be moved to a potential centralized base job that lives in s2i-openstack-containers, but I'm considering moving forward with this and have a dedicated follow up for this (which I think is already in our plans). cc @tosky

Note that we need a follow up anyway to target the ceph removal via install_yamls, but at that point this job will still be green because this patch migrates it to s2i+dummy backend

fmount · 2026-09-11T09:51:16Z

I'm going to put this patch on hold as we need to rebase it on top of #647 and rename the jobs.

centosinfra-prod-github-app · 2026-09-11T12:06:31Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/a714c8f875ad4420b1a4f81a1b4c1008

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 28m 59s
❌ manila-operator-kuttl FAILURE in 38m 23s
✔️ manila-s2i-content-provider SUCCESS in 1h 24m 30s
✔️ manila-operator-tempest SUCCESS in 1h 33m 52s

Signed-off-by: Francesco Pantano <fpantano@redhat.com>

Add cifmw overrides to consume s2i images coming from content provider and have a command to patch the csv where RELATED_IMAGES_* are replaced with what s2i provides. Signed-off-by: Francesco Pantano <fpantano@redhat.com>

centosinfra-prod-github-app · 2026-09-11T15:50:59Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/37fb44d3e03b4ce58550218bc8a85166

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 59m 57s
❌ manila-operator-kuttl FAILURE in 37m 12s
✔️ manila-s2i-content-provider SUCCESS in 1h 55m 50s
✔️ manila-operator-tempest SUCCESS in 1h 34m 19s

openshift-ci Bot requested review from silvacarloss and stuggi September 9, 2026 08:52

openshift-ci Bot added the approved label Sep 9, 2026

fmount force-pushed the dummy branch from 379c0bc to e1cedc7 Compare September 9, 2026 10:05

fmount marked this pull request as draft September 9, 2026 10:32

openshift-ci Bot added the do-not-merge/work-in-progress label Sep 9, 2026

fmount changed the title ~~Move multibackend job to dummy driver~~ WIP - Move multibackend job to dummy driver Sep 9, 2026

fmount marked this pull request as ready for review September 9, 2026 10:32

openshift-ci Bot requested a review from dprince September 9, 2026 10:32

fmount force-pushed the dummy branch from 009534b to f759422 Compare September 10, 2026 09:20

fmount force-pushed the dummy branch from f759422 to aff5edd Compare September 10, 2026 14:53

fmount force-pushed the dummy branch from aff5edd to 1ebc360 Compare September 10, 2026 19:39

fmount force-pushed the dummy branch from 1ebc360 to 9451d3c Compare September 11, 2026 09:30

fmount commented Sep 11, 2026

View reviewed changes

fmount changed the title ~~WIP - Move multibackend job to dummy driver~~ Move multibackend job to dummy driver Sep 11, 2026

openshift-ci Bot removed the do-not-merge/work-in-progress label Sep 11, 2026

fmount requested review from gouthampacha and tosky September 11, 2026 09:35

fmount added the do-not-merge/work-in-progress label Sep 11, 2026

openshift-ci Bot removed the do-not-merge/work-in-progress label Sep 11, 2026

fmount changed the title ~~Move multibackend job to dummy driver~~ Consume s2i content in kuttl tests Sep 11, 2026

fmount changed the title ~~Consume s2i content in kuttl tests~~ WIP - Consume s2i content in kuttl tests Sep 11, 2026

openshift-ci Bot added the do-not-merge/work-in-progress label Sep 11, 2026

fmount added do-not-merge/hold and removed do-not-merge/work-in-progress labels Sep 11, 2026

fmount added 3 commits September 11, 2026 14:44

Use s2i manila containers for kuttl

0d4d134

Signed-off-by: Francesco Pantano <fpantano@redhat.com>

try patching the csv

296ca16

Signed-off-by: Francesco Pantano <fpantano@redhat.com>

Update kuttl job with more cifmw variables

ab15acc

Add cifmw overrides to consume s2i images coming from content provider and have a command to patch the csv where RELATED_IMAGES_* are replaced with what s2i provides. Signed-off-by: Francesco Pantano <fpantano@redhat.com>

fmount force-pushed the dummy branch from 9451d3c to ab15acc Compare September 11, 2026 12:44

Conversation

fmount commented Sep 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Sep 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

openshift-ci Bot commented Sep 9, 2026

Uh oh!

fmount commented Sep 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

centosinfra-prod-github-app Bot commented Sep 9, 2026

Uh oh!

fmount commented Sep 9, 2026

Uh oh!

centosinfra-prod-github-app Bot commented Sep 9, 2026

Uh oh!

gouthampacha commented Sep 9, 2026

Uh oh!

centosinfra-prod-github-app Bot commented Sep 9, 2026

Uh oh!

fmount commented Sep 10, 2026

Uh oh!

centosinfra-prod-github-app Bot commented Sep 10, 2026

Uh oh!

centosinfra-prod-github-app Bot commented Sep 10, 2026

Uh oh!

centosinfra-prod-github-app Bot commented Sep 10, 2026

Uh oh!

fmount Sep 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fmount commented Sep 11, 2026

Uh oh!

centosinfra-prod-github-app Bot commented Sep 11, 2026

Uh oh!

centosinfra-prod-github-app Bot commented Sep 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fmount commented Sep 9, 2026 •

edited

Loading

coderabbitai Bot commented Sep 9, 2026 •

edited

Loading

fmount commented Sep 9, 2026 •

edited

Loading

fmount Sep 11, 2026 •

edited

Loading