Skip to content

feat: set transaction isolation to REPEATABLE_READ in DatabaseContext… #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mabduelaziz wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: set transaction isolation to REPEATABLE_READ in DatabaseContext… #164

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions osmosis-apidb/src/main/java/org/openstreetmap/osmosis/apidb/common/DatabaseContext2.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
import org.springframework.jdbc.datasource.DataSourceTransactionManager;
import org.springframework.jdbc.datasource.DataSourceUtils;
import org.springframework.transaction.PlatformTransactionManager;
import org.springframework.transaction.TransactionDefinition;
import org.springframework.transaction.support.TransactionCallback;
import org.springframework.transaction.support.TransactionTemplate;

Expand Down Expand Up @@ -47,6 +48,12 @@ public DatabaseContext2(DatabaseLoginCredentials loginCredentials) {
dataSource = DataSourceFactory.createDataSource(loginCredentials);
txnManager = new DataSourceTransactionManager(dataSource);
txnTemplate = new TransactionTemplate(txnManager);
// Use REPEATABLE READ so that all sequential reads within one osmosis dump
// (way_nodes read, then nodes geometry read, then relations read) share a
// single MVCC snapshot. Without this, READ COMMITTED lets a concurrent
// cgimap edit delete nodes between the two reads, producing ways with
// missing node references ("Way with less than two nodes" in osmium).
txnTemplate.setIsolationLevel(TransactionDefinition.ISOLATION_REPEATABLE_READ);
jdbcTemplate = new JdbcTemplate(dataSource);
this.dbType = loginCredentials.getDbType();

Expand Down