Add completeRelations option to pgsnapshot dataset bounding box filter - #36
Open
andreynovikov wants to merge 2 commits into
Open
Add completeRelations option to pgsnapshot dataset bounding box filter#36andreynovikov wants to merge 2 commits into
andreynovikov wants to merge 2 commits into
Conversation
Member
|
Hi @andreynovikov, it looks like the Travis build is failing for your pull request. Can you please take a look and fix any issues? It looks like it's just a checkstyle problem. You can see the travis logs by clicking the "Details" link next to the failed build above. |
Member
|
This PR seems like a good idea. I believe the failing build was the only thing blocking it from being merged previously. I'm always cautious about making changes to pgsnapshot because little changes can have major performance implications, however this change adds an optional feature that is disabled by default. It will also require some documentation updates. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.