Add port parameter to --wp - #47
Open
mvexel wants to merge 3 commits into
Open
Conversation
Member
|
Seems like a useful change, however the Checkstyle violations will need to be fixed first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
portparameter to set the port the PostgreSQL database is running at so you can doosmosis --rb planet/utah-latest.osm.pbf --wp database=osm port=5433 user=osmThis is convenient if you have multiple PostgreSQL instances running side by side or you are running the PostgreSQL server on some non-standard port for other reasons.
I did try
host=localhost:5433but that didn't work and also didn't seem like a very clean solution given thatpsqlfor example uses a separate parameter for it as well.