refactor: align deCODE harmonisation to shared config pattern and common/processing utilities#1244
Open
project-defiant wants to merge 1 commit into
Open
refactor: align deCODE harmonisation to shared config pattern and common/processing utilities#1244project-defiant wants to merge 1 commit into
project-defiant wants to merge 1 commit into
Conversation
…mon/processing utilities - Adopt common/processing helpers in deCODESummaryStatistics.from_source: replace private _infer_allele_frequency with shared infer_allele_frequency_from_maf; use flag_equal_alleles and flag_non_atgc_alleles in place of inline predicates - Collapse remove_star_alleles and remove_multiallelics into verify_atgc in both deCODESummaryStatisticsHarmonisationConfig and the step __init__ — the ATGC predicate already excludes both star and multiallelic markers - Remove inline Python defaults from deCODESummaryStatisticsHarmonisationStep __init__; all defaults are now declared once in the Hydra config dataclass - Rename deCODEHarmonisationConfig fields: min_mac → min_allele_count_threshold, min_sample_size → sample_size_threshold; add perform_* toggle booleans - Move DECODE_SCHEMA to module-level constant; add ConfigDict(extra="forbid") to deCODEHarmonisationConfig - Make EFOMapping.annotate_study_index generic (TypeVar S bound=StudyIndex) so it returns the concrete subclass type rather than base StudyIndex - Fix SessionConfig s3_configuration/gcs_configuration defaults to use field(default_factory=...) for Hydra structured config compatibility Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Context
This PR follows up on the unification of harmonisation efforts in gentropy. Here we focus on deCODE summary statistics harmonisation.
🛠 What does this PR implement
🙈 Missing
🚦 Before submitting
devbranch?make test)?uv run pre-commit run --all-files)?